Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-vendor MAPI headers from microsoft/MapiStubLibrary #2369

Merged
merged 4 commits into from
Oct 13, 2024

Conversation

Avasam
Copy link
Collaborator

@Avasam Avasam commented Sep 12, 2024

Re-vendors MAPI headers and library from https://github.com/microsoft/MAPIStubLibrary


The entirety of com/win32comext/mapi/src/MAPIStubLibrary/ is a direct copy of the source. Except for this text:


These MAPI headers were downloaded from microsoft/MAPIStubLibrary@5183a5f and enable us to build the MAPI extension.

in com/win32comext/mapi/src/MAPIStubLibrary/README.md


com/win32comext/mapi/src/extraMAPIDefs.h and com/win32comext/mapi/src/extraMAPIGuids.h have been moved out since they're not vendored files.

@Avasam Avasam changed the title Re-vendor MapiStubLibrary Re-vendor MAPI headers from microsoft/MapiStubLibrary Sep 12, 2024
@Avasam Avasam closed this Sep 15, 2024
@Avasam Avasam reopened this Sep 15, 2024
Copy link
Owner

@mhammond mhammond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks! Maybe later we could script this (although I guess the new location remains fairly static so probably not worth it yet)

@Avasam
Copy link
Collaborator Author

Avasam commented Oct 13, 2024

This is great, thanks! Maybe later we could script this (although I guess the new location remains fairly static so probably not worth it yet)

Given #2368 , I'm not too concerned about trying to stay actively in sync. It's also easy to just copy/paste an entire folder. But yeah, that could be done either through a vendoring script or git submodules.

@Avasam Avasam merged commit 22b0c0a into mhammond:main Oct 13, 2024
31 checks passed
@Avasam Avasam deleted the Re-vendor-MapiStubLibrary branch October 13, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants