-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI fixes #11
UI fixes #11
Conversation
Signed-off-by: Melanie Buehler <[email protected]>
Signed-off-by: Melanie Buehler <[email protected]>
Signed-off-by: Melanie Buehler <[email protected]>
# show_label=False, | ||
# container=False, | ||
label="Query", | ||
info="Enter your query here!", | ||
submit_btn=False, | ||
info="Enter a text query here", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this textbox shows up the same way for everyone's browser, but for me I need to click below the text in order to enter the prompt. For a while I was clicking on the "enter your query here" text trying to replace that text with my query, until I realized I need click under the text. If it's like that for others too, it might be more clear to say "Enter a text query below" or something like that. Or if it's possible to have a border on the textbox that could help too. But leaving it how you have it is fine too, just a small issue I wanted to mention.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that better, thanks
return gr.Textbox(visible=False) | ||
|
||
|
||
def clear_text(request: gr.Request): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't need to do anything?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The event listener that calls this is using the returned None value by assigning it to the designated output component, which is a Textbox. I agree it looks weird and I could return gr.Textbox(value=None)
but it would do the exact same thing.
Signed-off-by: Melanie Buehler <[email protected]>
Description
This PR contains the following UI fixes:
Issues
MultimodalQnA Audio/Image Enhancements RFC
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
None
Tests
Manually tested in the UI