Made all accessible GenAIExamples Ports dynamic #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: okhleif-IL <[email protected]>
Signed-off-by: okhleif-IL <[email protected]>
Signed-off-by: okhleif-IL <[email protected]>
Signed-off-by: okhleif-IL <[email protected]>
dmsuehir
requested changes
Dec 17, 2024
Signed-off-by: okhleif-IL <[email protected]>
dmsuehir
requested changes
Dec 17, 2024
dmsuehir
requested changes
Dec 17, 2024
Signed-off-by: okhleif-IL <[email protected]>
dmsuehir
requested changes
Dec 18, 2024
Signed-off-by: okhleif-IL <[email protected]>
Signed-off-by: okhleif-IL <[email protected]>
Signed-off-by: okhleif-IL <[email protected]>
Signed-off-by: okhleif-IL <[email protected]>
Signed-off-by: okhleif-IL <[email protected]>
dmsuehir
requested changes
Dec 21, 2024
Signed-off-by: okhleif-IL <[email protected]>
mhbuehler
requested changes
Dec 23, 2024
|
|
||
| export no_proxy=${no_proxy} | ||
| export http_proxy=${http_proxy} | ||
| export https_proxy=${http_proxy} |
There was a problem hiding this comment.
Are we allowed to change these? I'd probably keep them as they are, since it would be a global OPEA change.
| @@ -6,31 +6,46 @@ pushd "../../../../../" > /dev/null | |||
| source .set_env.sh | |||
| popd > /dev/null | |||
|
|
|||
| export no_proxy=${your_no_proxy} | |||
| export http_proxy=${your_http_proxy} | |||
| export https_proxy=${your_http_proxy} | |||
There was a problem hiding this comment.
Same here. Make sure you're not changing or deleting these unintentionally.
Signed-off-by: okhleif-IL <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reorganized the
set_env.shfiles, made compose files consistent with that. Edited tests and readme'sIssues
N/A
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
N/A
Tests
This can be tested by running the
test_compose_on_xeonandtest_compose_on_gaudiscripts