Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dockerfile clone so it points to our branch #36

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

mhbuehler
Copy link
Owner

Description

The megaservice tests don't pass unless we are cloning the mmqna-image-query branch. We will undo this and point to the main branch before merging upstream.

Issues

RFC

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Dependencies

N/A

Tests

I ran test_compose_on_xeon.sh to completion.

Copy link
Collaborator

@okhleif-IL okhleif-IL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks

@mhbuehler mhbuehler merged commit d2f8f64 into mmqna-image-query Dec 19, 2024
1 check failed
@mhbuehler mhbuehler deleted the melanie/dockerfile_clone_fix branch December 19, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants