Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compose.yaml to use fixed internal port for the whisper server #42

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

dmsuehir
Copy link
Collaborator

Description

This PR is based on a comment made in the GenAIComps PR. We really only need the external port to be configurable. We can hold on merging this until we hear back to Melanie's comment in the PR.

Issues

opea-project/GenAIComps#1134 (comment)

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Others (enhancement, documentation, validation, etc.)

Dependencies

N/A

Tests

Tested by using a different port externally vs internally:

$ docker ps
33ca0dedbfef   opea/whisper:latest                            "python whisper_serv…"   7 minutes ago   Up 7 minutes             0.0.0.0:7044->7066/tcp                           whisper-service
...

$ echo $WHISPER_SERVER_ENDPOINT
http://10.165.116.7:7044/v1/asr

$ curl ${WHISPER_SERVER_ENDPOINT}     -X POST     -H "Content-Type: application/json"     -d '{"audio" : "UklGRigAAABXQVZFZm10IBIAAAABAAEARKwAAIhYAQACABAAAABkYXRhAgAAAAEA"}'
{"asr_result":"you"}

@dmsuehir dmsuehir requested a review from mhbuehler as a code owner January 14, 2025 19:09
@dmsuehir dmsuehir merged commit 512a3f4 into mmqna-image-query Jan 16, 2025
1 check failed
@dmsuehir dmsuehir deleted the dina/revert-port branch January 16, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants