Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix env vars in the MMQnA test environment and align_inputs error #45

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

dmsuehir
Copy link
Collaborator

@dmsuehir dmsuehir commented Jan 14, 2025

Description

Embedding service tests are failing because the MMEI_EMBEDDING_ENDPOINT path was incorrect so when the embedding service was trying to call the bridgetower service, it was internally getting a 404. As you can see here, the /v1/encode part of the path is added later, so it shouldn't be part of the env var (otherwise it's double added). The README.sh and set_env.sh files already had the correct env var value.

The audio query test was failing due to WHISPER_SERVER_ENDPOINT missing.

Lastly, for image queries, align_inputs in multimodalqna.py was not supporting the format used for initial image queries (with dictionaries).

Issues

Test failures in opea-project#1381

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Dependencies

N/A

Tests

Ran MMQnA test scripts

@dmsuehir dmsuehir requested a review from mhbuehler as a code owner January 14, 2025 23:51
@dmsuehir dmsuehir changed the title Fix the MMEI_EMBEDDING_ENDPOINT env var in the MMQnA tests Fix the MMEI_EMBEDDING_ENDPOINT and WHISPER_SERVER_ENDPOINT env vars in the MMQnA tests Jan 15, 2025
Copy link
Owner

@mhbuehler mhbuehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dmsuehir dmsuehir changed the title Fix the MMEI_EMBEDDING_ENDPOINT and WHISPER_SERVER_ENDPOINT env vars in the MMQnA tests Fix env vars in the MMQnA test environment and align_inputs error Jan 15, 2025
@dmsuehir dmsuehir merged commit b426966 into mmqna-image-query Jan 15, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants