Added tests + updated docs for asr mp3 change #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: okhleif-IL <[email protected]>
dmsuehir
requested changes
Feb 4, 2025
| @@ -332,6 +332,9 @@ echo "This is an apple." > ${caption_fn} | |||
|
|
|||
| export audio_fn="AudioSample.wav" | |||
| wget https://github.com/intel/intel-extension-for-transformers/raw/main/intel_extension_for_transformers/neural_chat/assets/audio/sample.wav -O ${audio_fn} | |||
|
|
|||
| export audio_mp3_fn="sample_audio.mp3" | |||
| wget wget https://audio-samples.github.io/samples/mp3/blizzard_biased/sample-0.mp3 -O ${audio_mp3_fn} | |||
There was a problem hiding this comment.
Suggested change
| wget wget https://audio-samples.github.io/samples/mp3/blizzard_biased/sample-0.mp3 -O ${audio_mp3_fn} | |
| wget https://audio-samples.github.io/samples/mp3/blizzard_biased/sample-0.mp3 -O ${audio_mp3_fn} |
There was a problem hiding this comment.
Also, not sure on the licensing of this blizzard dataset. It might be safer to use another ITREX sample. For example:
wget https://github.com/intel/intel-extension-for-transformers/raw/refs/tags/v1.5/intel_extension_for_transformers/neural_chat/ui/customized/talkingbot/src/lib/components/talkbot/assets/mid-age-man.mp3
There was a problem hiding this comment.
Another idea is that instead of adding another audio file download to this example (the list of downloads is getting long), maybe the documentation should list what types of files are supported. For example, even for image ingestion, we support png, gif, and jpg, but I don't see that listed in the documentation. 🤔
| @@ -332,6 +332,9 @@ echo "This is an apple." > ${caption_fn} | |||
|
|
|||
| export audio_fn="AudioSample.wav" | |||
| wget https://github.com/intel/intel-extension-for-transformers/raw/main/intel_extension_for_transformers/neural_chat/assets/audio/sample.wav -O ${audio_fn} | |||
|
|
|||
| export audio_mp3_fn="sample_audio.mp3" | |||
| wget wget https://audio-samples.github.io/samples/mp3/blizzard_biased/sample-0.mp3 -O ${audio_mp3_fn} | |||
| ``` | |||
|
|
|||
| Test dataprep microservice with generating transcript. This command updates a knowledge base by uploading a local video .mp4 and an audio .wav file. | |||
There was a problem hiding this comment.
Add .mp3 to this sentence (if we are keeping mp3 as part of the example)
| @@ -116,6 +117,7 @@ function prepare_data() { | |||
| cd $LOG_PATH | |||
| echo "Downloading image and video" | |||
| wget https://github.com/docarray/docarray/blob/main/tests/toydata/image-data/apple.png?raw=true -O ${image_fn} | |||
| wget https://audio-samples.github.io/samples/mp3/blizzard_biased/sample-0.mp3 -O ${audio_fn} | |||
There was a problem hiding this comment.
Same comment about swapping this for an ITREX file
Signed-off-by: okhleif-IL <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added tests and updated documentation for mp3 ingestion feature.
Issues
N/A
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
N/A
Tests
Ran tests locally