Forget closed buffers #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove unnecessary .eslintignore (node_modules ignored by default.)
While the buffer list is fetched and replaced when (re)connecting, references to closed buffers may still exist in the hotlist, nicklist, and line states, as well as the currentBufferId field in the app state. Ensure that references to closed buffers are cleared out from the other states when the buffer list is fetched. Note that there is still a potential issue during upgrades if a pointer happens to be reused. Checking whether an upgade occurred while offline would be ideal, but it's an edge case.
mhoran
force-pushed
the
forget-closed-buffers
branch
from
94f52b4 to
beb5259
Compare
Now that the currentBufferId is properly set to null when an open buffer disappears (is closed in weechat or while disconnected), currentBufferId can be referenced without a guard checking buffer state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.