Push script improvements #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for multiple devices to receive push notifications.
Per Expo documentation, when the API responds with DeviceNotRegistered, notifications must not be sent to this device any further. Unfortuntaely this has proven difficult to test. After 24 hours, tokens from an uninstalled device and device with disabled notifications are still valid. However, testing with a completely invalid token (e.g. "invalid") shows that this works as expected.
mhoran
force-pushed
the
push-improvements
branch
from
7ac3718 to
4309105
Compare
mhoran
force-pushed
the
push-improvements
branch
from
4309105 to
9aa551a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.