Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we want to remove the repetition of component naming within component folders? #685

Open
Danielecina opened this issue Oct 30, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@Danielecina
Copy link
Member

Danielecina commented Oct 30, 2024

The description of the bug or the rationale of your proposal

Currently, we have a pattern similar to that in the components.

  • /Button/Button.tsx
  • /Button/index.tsx

The idea was to centralize the index.tsx everything we wanted to export about that component declaratively and not export everything by default.

Do we understand if we continue to like this aspect or change every part of the components to export all from index.tsx that contains the principal component

The new structure will be similar to this:

  • /Button/index.tsx

To date, it is certainly much more declarative and secure as to what we want to export things that we don't want to come out

@Danielecina Danielecina changed the title Remove repetition of component nomenclature within component folders Do we want to remove the repetition of component naming within component folders? Oct 30, 2024
@fredmaggiowski fredmaggiowski added the documentation Improvements or additions to documentation label Oct 31, 2024
@fredmaggiowski
Copy link
Member

fredmaggiowski commented Nov 14, 2024

yes please

i don't see a valid reason to have such repetition as it only provides cluttering in name and file management.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants