Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Dropdown): add placement prop #707

Merged
merged 10 commits into from
Nov 14, 2024
Merged

Conversation

malta895
Copy link
Member

@malta895 malta895 commented Nov 13, 2024

Description

Added Dropdown placement prop, which allows to set the placement of the dropdown relative to the parent

Dropdown
- added `placement` prop

[IMPORTANT] PR Checklist

  • I am aware of standards and conventions adopted in this repository, defined in the CONTRIBUTING.md file

PR conventions

Please make sure your PR complies with the following rules before submitting it.

  • PR title follows the <type>(<scope>): <subject> structure

  • The PR has been labeled according to the type of changes (e.g. enhancement, new component, bug).

    NOTE
    Some labels are used to generate release note entries: you can find the complete mapping between PR labels and release note categories here.
    For a more detailed overview of PR labels, please refer to the dedicated CONTRIBUTING section.

Additional code checks

Based on your changes, some of these checks may not apply. Please make sure to check the relevant items in the list.

  • Changes are covered by tests
  • Changes to components are accessible and documented in the Storybook
  • Typings have been updated
  • New components are exported from the src/index.ts file
  • New files include the Apache 2.0 License disclaimer
  • The browser console does not contain errors

@malta895 malta895 added enhancement New feature or request Dropdown component Label component and hooks related activities labels Nov 13, 2024
@malta895 malta895 marked this pull request as ready for review November 13, 2024 10:23
@malta895 malta895 requested a review from a team as a code owner November 13, 2024 10:23
Copy link
Member

@fredmaggiowski fredmaggiowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd improve the prop management

@malta895
Copy link
Member Author

I'd improve the prop management

Aside for the typing, and the default value, is there something else you think should be improved in props management?

Danielecina
Danielecina previously approved these changes Nov 13, 2024
Copy link
Member

@fredmaggiowski fredmaggiowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fredmaggiowski fredmaggiowski merged commit b7ebeff into main Nov 14, 2024
6 checks passed
@fredmaggiowski fredmaggiowski deleted the feat/dropdown-placement branch November 14, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dropdown component Label component and hooks related activities enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants