-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Dropdown): add placement prop #707
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd improve the prop management
Aside for the typing, and the default value, is there something else you think should be improved in props management? |
Co-authored-by: Federico Maggi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Added Dropdown
placement
prop, which allows to set the placement of the dropdown relative to the parentDropdown
[IMPORTANT] PR Checklist
PR conventions
Please make sure your PR complies with the following rules before submitting it.
PR title follows the
<type>(<scope>): <subject>
structureThe PR has been labeled according to the type of changes (e.g. enhancement, new component, bug).
Additional code checks
Based on your changes, some of these checks may not apply. Please make sure to check the relevant items in the list.
src/index.ts
file