Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Breadcrumb component #464

Merged
merged 69 commits into from
Jun 19, 2024
Merged

feat: add Breadcrumb component #464

merged 69 commits into from
Jun 19, 2024

Conversation

fedepini
Copy link
Contributor

@fedepini fedepini commented May 23, 2024 •
edited by epessina
Loading

Description

This PR has the goal of adding the Breadcrumb component to ease navigation between sections.

Screenshot 2024-06-12 at 16 30 50

Checklist

  • commit message and branch name follow conventions
  • tests are included
  • changes are accessible and documented from components stories
  • typings are updated or integrated accordingly with your changes
  • all added components are exported from index file (if necessary)
  • all added files include Apache 2.0 license
  • you are not committing extraneous files or sensible data
  • the browser console does not have any logged errors
  • necessary labels have been applied to this pull request (enhancement, bug, ecc.)

@fedepini fedepini requested a review from a team as a code owner May 23, 2024 14:56
@fedepini fedepini changed the title Draft: feat/breadcrumb component Draft: add Breadcrumb component May 23, 2024
@fedepini fedepini linked an issue May 23, 2024 that may be closed by this pull request
Add Breadcrumb component #463
Closed
@fedepini fedepini added enhancement New feature or request Breadcrumb component Breadcrumb component and hooks related activities new component labels Jun 4, 2024
@fedepini fedepini changed the title Draft: add Breadcrumb component Add Breadcrumb component Jun 4, 2024
@fedepini fedepini self-assigned this Jun 4, 2024
@epessina epessina marked this pull request as draft June 7, 2024 13:16
@fedepini fedepini changed the title Add Breadcrumb component feat: add Breadcrumb component Jun 10, 2024
@epessina epessina force-pushed the feat/breadcrumb-component branch 2 times, most recently from 1218429 to d922056 Compare June 12, 2024 14:17
@epessina epessina marked this pull request as ready for review June 12, 2024 14:17
@epessina epessina force-pushed the feat/breadcrumb-component branch from d953e46 to e5e6cd0 Compare June 13, 2024 07:13
epessina
epessina previously approved these changes Jun 13, 2024
View reviewed changes
fredmaggiowski
fredmaggiowski requested changes Jun 13, 2024
View reviewed changes
Copy link
Member

@fredmaggiowski fredmaggiowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dind't finish the review yet, I'm still missing a few files

src/components/Breadcrumb/assets/caret-full-down.svg Outdated Show resolved Hide resolved
src/components/Breadcrumb/Breadcrumb.utils.tsx Show resolved Hide resolved
src/components/Breadcrumb/Breadcrumb.utils.tsx Outdated Show resolved Hide resolved
src/components/Breadcrumb/Breadcrumb.types.ts Outdated Show resolved Hide resolved
src/components/Breadcrumb/Breadcrumb.tsx Show resolved Hide resolved
src/components/Breadcrumb/Breadcrumb.props.ts Outdated Show resolved Hide resolved
src/components/Breadcrumb/Breadcrumb.test.tsx Outdated Show resolved Hide resolved
src/components/Breadcrumb/Breadcrumb.module.css Show resolved Hide resolved
src/components/Breadcrumb/Breadcrumb.module.css Show resolved Hide resolved
src/components/Breadcrumb/Breadcrumb.Separator.tsx Outdated Show resolved Hide resolved
@epessina epessina mentioned this pull request Jun 17, 2024
Open
@epessina epessina linked an issue Jun 17, 2024 that may be closed by this pull request
Add missing CSS variables to align with Figma #497
Open
@epessina epessina removed a link to an issue Jun 17, 2024
Add missing CSS variables to align with Figma #497
Open
@epessina epessina force-pushed the feat/breadcrumb-component branch from 5468203 to 32fbd03 Compare June 18, 2024 12:32
fredmaggiowski
fredmaggiowski previously approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@fredmaggiowski fredmaggiowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@epessina epessina force-pushed the feat/breadcrumb-component branch from 4594769 to 9d891f2 Compare June 19, 2024 12:48
epessina
epessina previously approved these changes Jun 19, 2024
View reviewed changes
LiliumCandidum
LiliumCandidum previously approved these changes Jun 19, 2024
View reviewed changes
@epessina epessina dismissed stale reviews from LiliumCandidum and themself via 880232e June 19, 2024 12:53
@epessina epessina merged commit 841bfa4 into main Jun 19, 2024
6 checks passed
@epessina epessina deleted the feat/breadcrumb-component branch June 19, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrankieBortot FrankieBortot FrankieBortot left review comments

@epessina epessina epessina approved these changes

@LiliumCandidum LiliumCandidum LiliumCandidum approved these changes

@fredmaggiowski fredmaggiowski fredmaggiowski left review comments

Assignees

@fedepini fedepini

Labels
Breadcrumb component Breadcrumb component and hooks related activities enhancement New feature or request new component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Breadcrumb component
5 participants
@fedepini @fredmaggiowski @epessina @FrankieBortot @LiliumCandidum