Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: more deprecation warnings for Gleam stdlib #29

Merged
merged 5 commits into from
Nov 30, 2024

Conversation

GearsDatapacks
Copy link
Contributor

Hello, I'm back :) The stdlib deprecated more stuff

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe): Fixing deprecation warnings

What is the current behavior?

The code references deprecated stdlib types and values

Issue Number: N/A

What is the new

  • The code now uses the new names and modules for those types/values

Does this introduce a breaking change?

  • Yes
  • No

The current version of glitzer uses gleam/iterator which is now deprecated in favour of gleam/yielder. It uses it in the map_iterator, map2_iterator and each_iterator functions. I have renamed these to *_yielder as that is a better description of their new behaviour. Users would have to use the new function names, and use the Yielder type instead of Iterator.

If you don't want to release a breaking change just yet, we could introduce these new functions in addition to the existing ones, but deprecate the ones that still use Iterator, removing them at a later date.

Other information

@miampf
Copy link
Owner

miampf commented Nov 28, 2024

Hi, thanks again for your work :D . I'll probably take a closer look at it later this week

@miampf
Copy link
Owner

miampf commented Nov 30, 2024

Decided to only deprecate the iterator functions since I do not want to introduce breaking changes out of the blue if it is not strictly necessary. I will make a minor release later and add an additional deprecation warning there, in the future (latest at the beginning of next year) I will make a major release that removes the iterator functions so that they do not clobber up the code base and so that people are encouraged more to move away from the iterator package. Thank you again for your PR!

@miampf miampf merged commit 0f6226b into miampf:main Nov 30, 2024
1 check passed
@GearsDatapacks GearsDatapacks deleted the fix-deprecations branch November 30, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants