feat: allow public buckets, i.e. without auth #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalc
force-pushed
the
feat/allow-buckets-without-auth
branch
4 times, most recently
from
afe73c1
to
fee929a
Compare
michalc
changed the title
michalc
force-pushed
the
feat/allow-buckets-without-auth
branch
5 times, most recently
from
ae28818
to
eb4c1e7
Compare
It turns out that public buckets, so ones that don't require any auth, should not have any authentication headers at all. So allowing the `get_credentials` parameter to be `None`, in which case signing of requests and passing authentication headers is skipped. As discussed at #94
michalc
force-pushed
the
feat/allow-buckets-without-auth
branch
from
eb4c1e7
to
5066889
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that public buckets, so ones that don't require any auth, should not have any authentication headers at all. So allowing the
get_credentialsparameter to beNone, in which case signing of requests and passing authentication headers is skipped.As discussed at #94