Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve js code #44

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

loicknuchel
Copy link
Contributor

Here is a proposal to simplify workshop usage : you just have to implement projections and see if it's correct.

@tcoopman
Copy link
Collaborator

I'm going to think about this. I'm not sure if we want to go this far.
Personally I would like as little code as possible to get people started so that we don't force people into a structure/way of programming.
Maybe it would be a good idea to provide some sample solutions in a different branch if we want to do something like this. @michelgrootjans thoughts?

@loicknuchel
Copy link
Contributor Author

I think having some solutions in a separate folder can be enough, people will not look at them by error ;) (like this: https://github.com/loicknuchel/playing_with_projections/tree/add-js-solutions/js)

But this PR is more about structuring code and giving some feedback if result is OK or not...
The only structure here is : a function that take events and returns the expected result. People are free to code how they want inside it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants