Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mhtml-ts-mode #140

Merged
merged 1 commit into from
Apr 4, 2025
Merged

Conversation

gs-101
Copy link

@gs-101 gs-101 commented Mar 29, 2025

This mode was defined in emacs-mirror/emacs@05a96fd, a month ago.

I see that :major-modes works even when the user doesn't have the given mode installed, so merging this shouldn't cause any issues.

Also, I see that you have a development branch. Should PRs actually point to that instead?

@mickeynp
Copy link
Owner

Ideally the dev branch. I'll merge it to that branch if you open a PR.

@gs-101 gs-101 changed the base branch from master to development March 31, 2025 12:07
@gs-101
Copy link
Author

gs-101 commented Mar 31, 2025

Ideally the dev branch. I'll merge it to that branch if you open a PR.

I just changed the base branch here, but I'll if I need to do a rebase.

@gs-101 gs-101 force-pushed the feat/mhtml-ts-mode branch 2 times, most recently from 8dbbd62 to 72ead56 Compare March 31, 2025 12:15
@gs-101
Copy link
Author

gs-101 commented Mar 31, 2025

@mickeynp Seems like it's properly based on the development branch now.

@gs-101 gs-101 force-pushed the feat/mhtml-ts-mode branch from 72ead56 to 4fae1b8 Compare March 31, 2025 12:17
@gs-101
Copy link
Author

gs-101 commented Mar 31, 2025

One more force push to fix the author :v

@mickeynp mickeynp merged commit 6d36584 into mickeynp:development Apr 4, 2025
@gs-101 gs-101 deleted the feat/mhtml-ts-mode branch April 4, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants