-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Spresense board support #323
base: foxy
Are you sure you want to change the base?
Add Spresense board support #323
Conversation
Signed-off-by: Barry Xu <[email protected]> Co-authored-by: Chen Lihui <[email protected]>
Hello, just two comments:
|
Thanks for your comments.
Yes. I understand. These scrips (build_firmware.sh, etc) should not be modified. micro_ros_setup/scripts/build_firmware.sh Lines 72 to 76 in 720350f
I know you plan to remove official support to NuttX in micro-ROS Galactic. So foxy version also don't want to add any change for NuttX. Right ? |
Yes, you are right, And we will keep supporting NuttX on foxy, so feel free to include your port into this version. But in the future, only the new app will be used. |
Okay. Thank you.
Get it. |
README.md
Outdated
@@ -138,6 +141,7 @@ In summary, the supported configurations for transports are: | |||
| ST Nucleo H743ZI <sup>1</sup> | - | - | UART | | |||
| ST Nucleo F746ZG <sup>1</sup> | - | UART | UART | | |||
| ST Nucleo F767ZI <sup>1</sup> | - | UART | - | | |||
| Spresense | WiFi | - | - | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit:
| Spresense | WiFi | - | - | | |
| Spresense | Network | - | - | |
config/nuttx/spresense/configure.sh
Outdated
set -o pipefail | ||
|
||
|
||
# spresense use own sdk to config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit:
# spresense use own sdk to config | |
# spresense uses own sdk to config |
<name>firmware</name> | ||
<version>0.0.1</version> | ||
<description>This is a dummy package to supply firmware build dependencies for spresense.</description> | ||
<maintainer email="[email protected]">Ingo Luetkebohle</maintainer> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<maintainer email="[email protected].com">Ingo Luetkebohle</maintainer> | |
<maintainer email="Barry.Xu@sony.com">Barry Xu</maintainer> | |
<maintainer email="[email protected]">Tomoya Fujita</maintainer> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your review comments. I have addressed them at 4184ad9.
Signed-off-by: Barry Xu <[email protected]>
No description provided.