Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix mis-handled claim_jobs #305

Merged
merged 4 commits into from
Nov 26, 2024
Merged

fix mis-handled claim_jobs #305

merged 4 commits into from
Nov 26, 2024

Conversation

mbthornton-lbl
Copy link
Contributor

@mbthornton-lbl mbthornton-lbl commented Nov 26, 2024 •
edited
Loading

This PR provides a fix for a mishandled claim api response resulting in a KeyError

Log showing claim_jobs succeeding

2024-11-25 15:49:08,772 INFO: Found 1 unclaimed jobs.
2024-11-25 15:49:08,772 INFO: Claiming job nmdc:c2b7c884-ab78-11ef-8298-3e652b5abb3d
2024-11-25 15:49:08,775 DEBUG: Starting new HTTPS connection (1): api-dev.microbiomedata.org:443
2024-11-25 15:49:09,388 DEBUG: https://api-dev.microbiomedata.org:443 "POST /token HTTP/11" 200 None
2024-11-25 15:49:09,391 DEBUG: Starting new HTTPS connection (1): api-dev.microbiomedata.org:443
2024-11-25 15:49:14,907 DEBUG: https://api-dev.microbiomedata.org:443 "POST /jobs/nmdc:c2b7c884-ab78-11ef-8298-3e652b5abb3d:claim HTTP/11" 200 None

PR also provides updates to get_job_status:

  • Handling 404 errors from job runner
  • Fixing bugs with not looking in the correct place for cromwell_jobid and not updating status for Unknown

@mbthornton-lbl mbthornton-lbl requested a review from aclum November 26, 2024 00:01
@mbthornton-lbl mbthornton-lbl linked an issue Nov 26, 2024 that may be closed by this pull request
Watcher.claim_jobs failing with a KeyError #304
Closed
@mbthornton-lbl mbthornton-lbl linked an issue Nov 26, 2024 that may be closed by this pull request
Watcher fails with 404 error in job.get_job_status #306
Closed
@aclum aclum requested a review from shreddd November 26, 2024 19:41
@mbthornton-lbl mbthornton-lbl mentioned this pull request Nov 26, 2024
Merged
@mbthornton-lbl mbthornton-lbl merged commit eedecdb into main Nov 26, 2024
2 checks passed
@mbthornton-lbl mbthornton-lbl deleted the 304-watcherclaim_jobs-failing-with-a-keyerror branch November 26, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclum aclum aclum approved these changes

@scanon scanon Awaiting requested review from scanon

@shreddd shreddd Awaiting requested review from shreddd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Watcher fails with 404 error in job.get_job_status Watcher.claim_jobs failing with a KeyError
2 participants
@mbthornton-lbl @aclum