-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle error responses from API token endpoint #325
Merged
mbthornton-lbl
merged 8 commits into
main
from
317-watcher-get-401-unauthorized-error-from-jobs-endpoint
Dec 17, 2024
Merged
Handle error responses from API token endpoint #325
mbthornton-lbl
merged 8 commits into
main
from
317-watcher-get-401-unauthorized-error-from-jobs-endpoint
Dec 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreddd
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable
aclum
approved these changes
Dec 10, 2024
scanon
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
You could add a few unit tests for this.
where is the 401 handling? |
Cannot replicate the error with client with expired token
mbthornton-lbl
changed the title
Handle token expiration in day(s) or minutes
Handle error responses from API token endpoint
Dec 17, 2024
shreddd
approved these changes
Dec 17, 2024
aclum
approved these changes
Dec 17, 2024
mbthornton-lbl
deleted the
317-watcher-get-401-unauthorized-error-from-jobs-endpoint
branch
December 17, 2024 22:54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR seeks to address a failure where the Watcher gets a 401 unauthorized response from the
jobs
endpoint.Underlying cause appears to be a non-200 return from the
/token
endpoint. This PR seeks to address this by:tenacity
python lib to projectget_token
with@retry
with exponential backoff@pytest.mark.integration
tests