Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor nmdc_automation unit tests and add basic CI #34

Merged
merged 67 commits into from
Dec 13, 2023

Conversation

mbthornton-lbl
Copy link
Contributor

This PR provides the following changes to nmdc_automation:

  • Refactoring existing unit tests to fix import and other minor issues
  • Refactoring some of the non-functional unit tests in jgi_file_staging unit tests - import and other minor issues only
  • Implementing basic Build, Lint and Test workflow via GH Actions

Note: Some remaining tests in jgi_file_staging will still need repairs - the issues are more significant - primarily test fixtures with data that does not validate vs. the Sample model

Copy link

@Michal-Babins Michal-Babins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests bar the jgi_file transfer code and the jawsapi are tested and pass. Github actions are succesful in setting up environment, linting, running pytests, and having completed.

Coverage badge only at 63% but gaps are known and will be fixed in future PR's. Current changes cover testing and github actions needed to implement workflow automation and import automation.

@Michal-Babins Michal-Babins merged commit 23a0ace into main Dec 13, 2023
1 check passed
@mbthornton-lbl mbthornton-lbl deleted the Refactor_fgi_file_staging_unit_tests branch January 2, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants