Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 优化 rjvId 生成方式,添加随机字符串增加唯一性 #60

Merged
merged 1 commit into from
Feb 13, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 13 additions & 20 deletions src/js/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ class ReactJsonView extends React.PureComponent {
}

// reference id for this instance
rjvId = Date.now().toString()
rjvId = Date.now().toString() + Math.random().toString(36).slice(2)

// all acceptable props and default values
static defaultProps = {
Expand Down Expand Up @@ -205,46 +205,39 @@ class ReactJsonView extends React.PureComponent {
}

updateSrc = () => {
const {
name,
namespace,
new_value,
existing_value,
variable_removed,
updated_src,
type
} = ObjectAttributes.get(this.rjvId, 'action', 'variable-update')
const { name, namespace, newValue, existingValue, updatedSrc, type } =
ObjectAttributes.get(this.rjvId, 'action', 'variable-update')
const { onEdit, onDelete, onAdd } = this.props

const { src } = this.state

let result

const on_edit_payload = {
existing_src: src,
new_value,
updated_src,
const onEditPayload = {
existingSrc: src,
newValue,
updatedSrc,
name,
namespace,
existing_value
existingValue
}

switch (type) {
case 'variable-added':
result = onAdd(on_edit_payload)
result = onAdd(onEditPayload)
break
case 'variable-edited':
result = onEdit(on_edit_payload)
result = onEdit(onEditPayload)
break
case 'variable-removed':
result = onDelete(on_edit_payload)
result = onDelete(onEditPayload)
break
}

if (result !== false) {
ObjectAttributes.set(this.rjvId, 'global', 'src', updated_src)
ObjectAttributes.set(this.rjvId, 'global', 'src', updatedSrc)
this.setState({
src: updated_src
src: updatedSrc
})
} else {
this.setState({
Expand Down