Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed double logged train loss and boolean parser #91

Merged
merged 2 commits into from
May 27, 2024

Conversation

MarognaLorenzo
Copy link
Contributor

1. train loss was logged twice at training time.

The bug was not creating any malfunctioning in the training process, but the train loss was read as double its actual amount in the `train_log.txt'.

2. Boolean parser was not working properly

Boolean parameters can now be passed in the form:
python train.py --<numeric_parameter>=256 --<boolean_parameter_true>=True --<boolean_parameter_false>=False --<boolean_parameter_true>=1 --<boolean_parameter_false>=0 --<boolean_parameter_true>=y --<boolean_parameter_false>=n
and will be processed correctly. Before, any value passed was evaluated as True

@fpaissan fpaissan self-requested a review May 27, 2024 07:25
Copy link
Collaborator

@fpaissan fpaissan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, already checked and discussed together.

@fpaissan fpaissan merged commit 8ba8912 into micromind-toolkit:dev May 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants