Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: using Micronaut's Response.getReason instead of javax core Response #1168

Open
wants to merge 1 commit into
base: 5.0.x
Choose a base branch
from

Conversation

jmktam
Copy link

@jmktam jmktam commented Aug 30, 2021

Using Micronaut's Response.getReason instead of javax core Response.Status.getReasonPhrase.

Issue:
When using AWS ALB, the ResponseWriter attempts to get get the response phrase from javax core's Response.Status. However, javax core's Respons.Status implements a subset of Http Response codes that Micronaut supports. This results in a null pointer exception.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Tam seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jmktam jmktam changed the title using Micronaut's Response.getReason instead of javax core Response.S… fix: using Micronaut's Response.getReason instead of javax core Response Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants