-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move away from Jackson #1323
Open
timyates
wants to merge
20
commits into
5.0.x
Choose a base branch
from
remove-jackson
base: 5.0.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Move away from Jackson #1323
Changes from 7 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
f8d1ac3
Settings to 5.3.1 and update build
timyates fadb85b
Remove BOM from catalog as it fails bomcheck
timyates 0fc14d6
Use version from catalog for boms
timyates d22a685
Cleanup gradle.properties
timyates 8e6df2c
More metaspace for Sonar
timyates f791a7c
Up to 5.3.2 and fix boms accordingly
timyates 46ad900
Start with function-aws-api-proxy to gather feedback
timyates 0233b83
Merge branch 'master' into remove-jackson
sdelamo 0d4ca45
Use processor, import classes to abstract runtime, try to fix tests
timyates 3f00ec0
inject java annotation processor so serde processor picks up java tes…
timyates 6446fc0
Ignore failing validation test for now
timyates 02afcb5
Document JAPICMP violations
timyates 8089f30
Reinstate ignored test now we know the problem
timyates dca8a6c
More updates
timyates ce9dcbf
Unserialized errors and RequestEnvelope deserialization remain
timyates cb73990
Remove custom ObjectMapper and docs for it
timyates 6fecc10
Leave Jackson in AWS Alexa module
timyates df8d67c
Undo whitespace change
timyates 599267d
Merge branch 'master' into remove-jackson
timyates 745a03d
Fix merge
timyates File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,9 +28,7 @@ | |
|
||
import com.fasterxml.jackson.core.JsonParseException; | ||
import com.fasterxml.jackson.databind.JsonMappingException; | ||
import com.fasterxml.jackson.databind.ObjectMapper; | ||
import com.fasterxml.jackson.databind.ObjectReader; | ||
import com.fasterxml.jackson.databind.ObjectWriter; | ||
import io.micronaut.json.JsonMapper; | ||
import org.slf4j.Logger; | ||
import org.slf4j.LoggerFactory; | ||
|
||
|
@@ -119,7 +117,7 @@ protected AbstractLambdaContainerHandler(Class<RequestType> requestClass, | |
* | ||
* @return Return the object mapper. | ||
*/ | ||
protected abstract ObjectMapper objectMapper(); | ||
protected abstract JsonMapper objectMapper(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is a |
||
|
||
/** | ||
* Gets a writer for the given response class. | ||
|
@@ -133,7 +131,7 @@ protected AbstractLambdaContainerHandler(Class<RequestType> requestClass, | |
* @param requestClass The request class | ||
* @return The reader | ||
*/ | ||
protected abstract ObjectReader readerFor(Class<RequestType> requestClass); | ||
protected abstract ObjectReader<RequestType> readerFor(Class<RequestType> requestClass); | ||
|
||
/** | ||
* Get the container response. | ||
|
@@ -258,4 +256,17 @@ public void proxyStream(InputStream input, OutputStream output, Context context) | |
public static ContainerConfig getContainerConfig() { | ||
return config; | ||
} | ||
|
||
@FunctionalInterface | ||
interface ObjectWriter { | ||
|
||
void writeValue(OutputStream os, Object value) throws IOException; | ||
} | ||
|
||
@FunctionalInterface | ||
interface ObjectReader<T> { | ||
|
||
T readValue(InputStream input) throws IOException; | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend to update the build to 3.4.0,
githubCoreBranch
to 3.5.0 and use the serde version in the BOM.