Add missing annotation processors for micronaut modules. #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdelamo
requested changes
Nov 15, 2023
|
I added tests. Note that the way this is done is not ideal, since indeed the plugin needs to know about all other projects. There is no obvious way to make it better, it's a bit of a chicken and egg problem. |
melix
approved these changes
Nov 15, 2023
|
Kudos, SonarCloud Quality Gate passed! |
sdelamo
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #871
@melix @sdelamo
micronaut-tracing and micronaut-spring have multiple possible annotation processors. I included the primary ones. Do we need to add the others? If so then the implementation needs to be changed because it's based on a map with groupIds for keys.
These are the ones I didn't add:
@melix Also, I didn't see an obvious way this is tested, so I didn't change anything for the new ones either. Happy for any guidance.