Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing configuration parameter #900

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Add missing configuration parameter #900

merged 3 commits into from
Dec 4, 2023

Conversation

melix
Copy link
Collaborator

@melix melix commented Dec 4, 2023

This was left over when upgrading to test resources 2.3.0.

Fixes #875

@melix
Add missing configuration parameter
9c0e9b1 
This was left over when upgrading to test resources 2.3.0.

Fixes #875
@melix melix requested a review from timyates December 4, 2023 10:54
@melix melix self-assigned this Dec 4, 2023
@melix melix added this to the 4.2.1 milestone Dec 4, 2023
timyates
timyates reviewed Dec 4, 2023
View reviewed changes
Copy link
Contributor

@timyates timyates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need adding to https://github.com/micronaut-projects/micronaut-gradle-plugin/blob/cc/issue-875/src/docs/asciidoc/index.adoc?plain=1#L1478

@melix
Copy link
Collaborator Author

melix commented Dec 4, 2023

Good point, added!

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@melix melix merged commit 315cab2 into master Dec 4, 2023
8 checks passed
@melix melix deleted the cc/issue-875 branch December 4, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timyates timyates timyates approved these changes

Assignees

@melix melix

Labels
relates-to: test-resources type: enhancement New feature or request
Projects
No open projects
4.2.1 Release
Status: Done
Milestone
4.2.1
Development

Successfully merging this pull request may close these issues.

Support test resources idle timeout
2 participants
@melix @timyates