Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Micronaut-openapi 6.7.0 #950

Merged

Conversation

altro3
Copy link
Contributor

@altro3 altro3 commented Mar 1, 2024

Added test to clientId generator property

Fixed #949

@altro3 altro3 marked this pull request as ready for review March 4, 2024 17:52
@timyates
Copy link
Contributor

timyates commented Mar 21, 2024

We've already merged 6.6.3 #961

I want to make a patch release for 4.3.5 of the Gradle plugin as there's bug fixes in it

4.3.5 of the gradle plugin will then go out with 4.3.7 of Micronaut (next patch)

Ideally, we shouldn't wait for Micronaut 4.4.0 (next minor) to include the bugfixes

Unless you're saying I should revert the update to 6.6.3?

@timyates
Copy link
Contributor

@altro3 this pr only makes a single change

https://github.com/micronaut-projects/micronaut-gradle-plugin/pull/950/files#diff-0d8feb3d2e60a4085c22391e83952def203f6d69a5ae209e04b1886d52a971f9

(plus 2 tests)

Should it be closed then?

Or should I revert the 6.6.3 update?

@altro3
Copy link
Contributor Author

altro3 commented Mar 21, 2024

I'll change this PR to 6.7.0. In 6.7.0 will be one more property. Need to add it here. I'll do it timorrow

@timyates timyates marked this pull request as draft March 21, 2024 13:26
@timyates
Copy link
Contributor

timyates commented Mar 21, 2024

@altro3 should I revert the 6.6.3 update for the next patch release of this plugin?

We (obviously) cannot release 6.7.0 (a minor update) in a patch plugin release

And I want the patch plugin for the next patch micronaut release

@altro3
Copy link
Contributor Author

altro3 commented Mar 21, 2024

It desn't matter. With 6.6.3 all works fine, but as I remeber I've added one more property for configuration. And all that is not completed is that you will not be able to set this property through the plugin.

@timyates
Copy link
Contributor

Ok, I'll leave this PR in draft for now, but release 4.3.5 of the plugin with 6.6.3 of the openapi generator

@sdelamo
Copy link
Contributor

sdelamo commented Mar 21, 2024

Lets go ahead with the patch release of the gradle plugin and then we can make a minor release with the minor of open api

@altro3 altro3 force-pushed the add-test-to-generator-client-id branch 2 times, most recently from 319ac3f to 5796fb7 Compare March 22, 2024 07:35
@altro3 altro3 changed the title Micronaut-openapi 6.6.3 Micronaut-openapi 6.7.0 Mar 22, 2024
@altro3 altro3 force-pushed the add-test-to-generator-client-id branch 2 times, most recently from dace684 to 4648f0f Compare March 29, 2024 04:34
@altro3 altro3 marked this pull request as ready for review March 29, 2024 04:34
@altro3 altro3 force-pushed the add-test-to-generator-client-id branch 2 times, most recently from 96b6a09 to 28efe23 Compare March 29, 2024 08:20
Added test to clientId generator property
@altro3 altro3 force-pushed the add-test-to-generator-client-id branch from 28efe23 to d15ea38 Compare March 29, 2024 09:09
@altro3
Copy link
Contributor Author

altro3 commented Mar 29, 2024

@timyates @melix All ready to review and merge

@melix melix merged commit e76e07f into micronaut-projects:master Apr 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

clientId not set on generated class
4 participants