Arquillian version updated #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yasmin is trying to execute the tests to find out whether the tests can be executed. |
radcortez
requested changes
Oct 14, 2022
There was a problem hiding this comment.
Please, do not update individual versions of dependencies. This defeats the entire purpose of the BOM.
The BOM includes TestNG 7.4, but Arquillian uses 7.5: https://github.com/arquillian/arquillian-core/blob/1.7.0.Alpha12/build/pom.xml#L31
These need to be in-sync or it can cause issues when running the TCK.
|
@radcortez this was intended to fix potential errors in the mentioned issue temporary - we can skip this here and do it on the microprofile-parent/tck-bom with aligned versions, if you like. |
|
I think this PR should be marked as Experimental to avoid confusion. Let's close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for a MP Telemetry Tracing TCK local Arquillian update to 1.7.0.Alpha12.
Alternatively the update can be done in the microprofile-parent project (PR is available), but this would require a new release there and then updating the mircroprofile-tck-bom version here.
This PR is intended to fix TCK issues #58 and #53.