Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix placeholder syntax in PR Handler action #1145

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

cegekaJG
Copy link
Contributor

This PR fixes an error introduced by #1130.
The new reference values use the format() command to generate a git reference, but the placeholder syntax was incorrect.
The two instances of ${0} per template have been replaced with {0}.

@cegekaJG cegekaJG requested a review from a team as a code owner July 16, 2024 10:27
mazhelez
mazhelez previously approved these changes Jul 17, 2024
Copy link
Collaborator

@mazhelez mazhelez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also add a line in the release notes.

@cegekaJG
Copy link
Contributor Author

Maybe also add a line in the release notes.

Do you mean a line explaining this PR in the "Issues"-section? I figured it wouldn't be necessary since this only fixes a change that is still only in the preview.

@mazhelez
Copy link
Collaborator

Maybe also add a line in the release notes.

Do you mean a line explaining this PR in the "Issues"-section? I figured it wouldn't be necessary since this only fixes a change that is still only in the preview.

Exactly because it is already shipped in preview. Repositories running on preview will get the There are updates for your AL-Go system, run 'Update AL-Go System Files' workflow to download the latest version of AL-Go. message and the release notes should explain what these changes are.

It's not a requirement, but a recommendation.

freddydk
freddydk previously approved these changes Jul 17, 2024
@cegekaJG cegekaJG dismissed stale reviews from freddydk and mazhelez via 5e444d7 July 18, 2024 06:58
@freddydk freddydk merged commit df1db5d into microsoft:main Jul 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants