-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Git submodule support #1287
Conversation
@microsoft-github-policy-service agree |
I actually didn't know about submodules until now. BTW - you do know that your project above is publicly visible right? |
You might be right, I'll update the rest of the yaml files. At first I tried to add it in the cicd.yaml but it still didn't work, then I found it worked by adding in _BuildALGoProject.yaml instead. Yes I'm aware it's a public repo, nothing to worry about it, I don't plan on deploy it anywhere, it's merely my playground to test. |
You also need to update the same yaml files in the AppSource App/.github/workflows folder. |
Done, sorry I missed those |
One more thing, sorry for forgetting. Could you add a section to releasenotes.md (under support for page scripting) following the same style, explaining what this is and how to use it (linking to github docs probably - not private repos). Thanks. |
Sure thing. I've added it though I'm not sure whether it's good enough to explain git submodule. You're welcome to make it fits. |
Might be added later in scenarios
We have decided to take this as experimental support and merge it. |
@dibyanugraha - we have received an issue #1344 - which is another partner using git submodules for other things. Are you only using this for public repositories? |
I use git submodule instead of putting the extension source codes directly in the repo, to my surprise it doesn't automatically initialize the submodule thus failing the automatic build.
These changes should make the workflow is able to initialize any git submodules inside the repo thus making the automatic build passes.
Tested in this repo https://github.com/dibyanugraha/d365-bc-toastui-calendar-control-addin-cicd