Only needed secrets

Actions/AddExistingApp/AddExistingApp.ps1

@@ -83,6 +83,7 @@ $telemetryScope = $null
 $bcContainerHelperPath = $null
 
 # IMPORTANT: No code that can fail should be outside the try/catch
+# IMPORTANT: All actions needs a try/catch here and not only in the yaml file, else they can silently fail
 
 try {
     . (Join-Path -Path $PSScriptRoot -ChildPath "..\AL-Go-Helper.ps1" -Resolve)
@@ -189,7 +190,7 @@ try {
             try {
                 $settingsJsonFile = Join-Path $projectFolder $ALGoSettingsFile
                 $SettingsJson = Get-Content $settingsJsonFile -Encoding UTF8 | ConvertFrom-Json
-                if (@($settingsJson.appFolders)+@($settingsJson.testFolders)) {
+                if (@($settingsJson.appFolders) + @($settingsJson.testFolders)) {
                     if ($ttype -eq "Test App") {
                         if ($SettingsJson.testFolders -notcontains $foldername) {
                             $SettingsJson.testFolders += @($folderName)
@@ -219,7 +220,7 @@ try {
                     $workspace | Set-JsonContentLF -Path $workspaceFile
                 }
                 catch {
-                   throw "$workspaceFileName is malformed.$([environment]::Newline) $($_.Exception.Message)"
+                    throw "$workspaceFileName is malformed.$([environment]::Newline) $($_.Exception.Message)"
                 }
             }
         }

Actions/AnalyzeTests/AnalyzeTests.ps1

@@ -14,6 +14,7 @@ $telemetryScope = $null
 $bcContainerHelperPath = $null
 
 # IMPORTANT: No code that can fail should be outside the try/catch
+# IMPORTANT: All actions needs a try/catch here and not only in the yaml file, else they can silently fail
 
 try {
     . (Join-Path -Path $PSScriptRoot -ChildPath "..\AL-Go-Helper.ps1" -Resolve)

Actions/CalculateArtifactNames/CalculateArtifactNames.ps1

@@ -17,41 +17,47 @@ function Set-EnvVariable([string] $name, [string] $value) {
 
 $errorActionPreference = "Stop"; $ProgressPreference = "SilentlyContinue"; Set-StrictMode -Version 2.0
 
-$settings = $env:Settings | ConvertFrom-Json
-
-if ($project -eq ".") { 
-  $project = $settings.repoName 
-}
-
-$branchName = $branchName.Replace('\','_').Replace('/','_')
-$projectName = $project.Replace('\','_').Replace('/','_')
-
-# If the buildmode is default, then we don't want to add it to the artifact name
-if ($buildMode -eq 'Default') { 
-  $buildMode = '' 
-}
-Set-EnvVariable -name "BuildMode" -value $buildMode
-
-if($suffix) {
-  # Add the date to the suffix 
-  $suffix = "$suffix-$([DateTime]::UtcNow.ToString('yyyyMMdd'))"
+# IMPORTANT: No code that can fail should be outside the try/catch
+# IMPORTANT: All actions needs a try/catch here and not only in the yaml file, else they can silently fail
+
+try {
+    $settings = $env:Settings | ConvertFrom-Json
+
+    if ($project -eq ".") { 
+        $project = $settings.repoName 
+    }
+
+    $branchName = $branchName.Replace('\', '_').Replace('/', '_')
+    $projectName = $project.Replace('\', '_').Replace('/', '_')
+
+    # If the buildmode is default, then we don't want to add it to the artifact name
+    if ($buildMode -eq 'Default') { 
+        $buildMode = '' 
+    }
+    Set-EnvVariable -name "BuildMode" -value $buildMode
+
+    if ($suffix) {
+        # Add the date to the suffix 
+        $suffix = "$suffix-$([DateTime]::UtcNow.ToString('yyyyMMdd'))"
+    }
+    else {
+        # Default suffix is the build number
+        $suffix = "$($settings.repoVersion).$($settings.appBuild).$($settings.appRevision)"
+    }
+
+    'Apps', 'Dependencies', 'TestApps', 'TestResults', 'BcptTestResults', 'BuildOutput', 'ContainerEventLog' | ForEach-Object {
+        $name = "$($_)ArtifactsName"
+        $value = "$($projectName)-$($branchName)-$buildMode$_-$suffix"
+        Set-EnvVariable -name $name -value $value
+    }
+
+    # Set this build artifacts name
+    'Apps', 'TestApps' | ForEach-Object {
+        $name = "ThisBuild$($_)ArtifactsName"
+        $value = "thisbuild-$($projectName)-$($buildMode)$($_)"
+        Set-EnvVariable -name $name -value $value
+    }
 }
-else {
-  # Default suffix is the build number
-  $suffix = "$($settings.repoVersion).$($settings.appBuild).$($settings.appRevision)"
-}
-
-'Apps','Dependencies','TestApps','TestResults','BcptTestResults','BuildOutput','ContainerEventLog' | ForEach-Object {
-  $name = "$($_)ArtifactsName"
-  $value = "$($projectName)-$($branchName)-$buildMode$_-$suffix"
-
-  Set-EnvVariable -name $name -value $value
-}
-
-# Set this build artifacts name
-'Apps', 'TestApps' | ForEach-Object {
-  $name = "ThisBuild$($_)ArtifactsName"
-  $value = "thisbuild-$($projectName)-$($buildMode)$($_)"
-
-  Set-EnvVariable -name $name -value $value
+catch {
+    OutputError -message "AnalyzeTests action failed.$([environment]::Newline)Error: $($_.Exception.Message)$([environment]::Newline)Stacktrace: $($_.scriptStackTrace)"
 }

Actions/CheckForUpdates/CheckForUpdates.ps1

@@ -22,6 +22,7 @@ $telemetryScope = $null
 $bcContainerHelperPath = $null
 
 # IMPORTANT: No code that can fail should be outside the try/catch
+# IMPORTANT: All actions needs a try/catch here and not only in the yaml file, else they can silently fail
 
 try {
     . (Join-Path -Path $PSScriptRoot -ChildPath "..\AL-Go-Helper.ps1" -Resolve)

Actions/CreateApp/CreateApp.ps1

@@ -32,6 +32,7 @@ $bcContainerHelperPath = $null
 $tmpFolder = Join-Path ([System.IO.Path]::GetTempPath()) ([Guid]::NewGuid().ToString())
 
 # IMPORTANT: No code that can fail should be outside the try/catch
+# IMPORTANT: All actions needs a try/catch here and not only in the yaml file, else they can silently fail
 
 try {
     . (Join-Path -Path $PSScriptRoot -ChildPath "..\AL-Go-Helper.ps1" -Resolve)
@@ -67,7 +68,7 @@ try {
     if ($type -eq "Performance Test App") {
         try {
             $settings = ReadSettings -baseFolder $baseFolder -project $project
-            $settings = AnalyzeRepo -settings $settings -token $token -baseFolder $baseFolder -project $project -doNotIssueWarnings
+            $settings = AnalyzeRepo -settings $settings -token $token -baseFolder $baseFolder -project $project -doNotIssueWarnings -doNotCheckAppDependencyProbingPaths
             $folders = Download-Artifacts -artifactUrl $settings.artifact -includePlatform
             $sampleApp = Join-Path $folders[0] "Applications.*\Microsoft_Performance Toolkit Samples_*.app"
             if (Test-Path $sampleApp) {

Actions/CreateDevelopmentEnvironment/CreateDevelopmentEnvironment.ps1

@@ -24,6 +24,7 @@ $telemetryScope = $null
 $bcContainerHelperPath = $null
 
 # IMPORTANT: No code that can fail should be outside the try/catch
+# IMPORTANT: All actions needs a try/catch here and not only in the yaml file, else they can silently fail
 
 try {
     . (Join-Path -Path $PSScriptRoot -ChildPath "..\AL-Go-Helper.ps1" -Resolve)

Actions/CreateReleaseNotes/CreateReleaseNotes.ps1

@@ -16,6 +16,7 @@ $telemetryScope = $null
 $bcContainerHelperPath = $null
 
 # IMPORTANT: No code that can fail should be outside the try/catch
+# IMPORTANT: All actions needs a try/catch here and not only in the yaml file, else they can silently fail
 
 try {
     . (Join-Path -Path $PSScriptRoot -ChildPath "..\AL-Go-Helper.ps1")

Actions/Deliver/Deliver.ps1

@@ -47,6 +47,7 @@ function EnsureAzStorageModule() {
 }
 
 # IMPORTANT: No code that can fail should be outside the try/catch
+# IMPORTANT: All actions needs a try/catch here and not only in the yaml file, else they can silently fail
 
 try {
     $baseFolder = $ENV:GITHUB_WORKSPACE
@@ -187,7 +188,7 @@ try {
             Write-Host "Found custom script $customScript for delivery target $deliveryTarget"
 
             $projectSettings = ReadSettings -baseFolder $baseFolder -project $thisProject
-            $projectSettings = AnalyzeRepo -settings $projectSettings -baseFolder $baseFolder -project $thisProject -doNotCheckArtifactSetting -doNotIssueWarnings
+            $projectSettings = AnalyzeRepo -settings $projectSettings -baseFolder $baseFolder -project $thisProject -doNotCheckArtifactSetting -doNotCheckAppDependencyProbingPaths -doNotIssueWarnings
             $parameters = @{
                 "Project" = $thisProject
                 "ProjectName" = $projectName
@@ -408,7 +409,7 @@ try {
         }
         elseif ($deliveryTarget -eq "AppSource") {
             $projectSettings = ReadSettings -baseFolder $baseFolder -project $thisProject
-            $projectSettings = AnalyzeRepo -settings $projectSettings -baseFolder $baseFolder -project $thisProject -doNotCheckArtifactSetting -doNotIssueWarnings
+            $projectSettings = AnalyzeRepo -settings $projectSettings -baseFolder $baseFolder -project $thisProject -doNotCheckArtifactSetting -doNotCheckAppDependencyProbingPaths -doNotIssueWarnings
             # if type is Release, we only get here with the projects that needs to be delivered to AppSource
             # if type is CD, we get here for all projects, but should only deliver to AppSource if AppSourceContinuousDelivery is set to true
             if ($type -eq 'Release' -or ($projectSettings.Keys -contains 'AppSourceContinuousDelivery' -and $projectSettings.AppSourceContinuousDelivery)) {

Actions/Deploy/Deploy.ps1

@@ -22,10 +22,11 @@ $bcContainerHelperPath = $null
 
 if ($projects -eq '') {
     Write-Host "No projects to deploy"
+    exit
 }
-else {
 
 # IMPORTANT: No code that can fail should be outside the try/catch
+# IMPORTANT: All actions needs a try/catch here and not only in the yaml file, else they can silently fail
 
 try {
     . (Join-Path -Path $PSScriptRoot -ChildPath "..\AL-Go-Helper.ps1" -Resolve)
@@ -197,4 +198,3 @@ catch {
 finally {
     CleanupAfterBcContainerHelper -bcContainerHelperPath $bcContainerHelperPath
 }
-}

Actions/DetermineArtifactUrl/DetermineArtifactUrl.ps1

@@ -2,16 +2,15 @@ Param(
     [Parameter(HelpMessage = "Specifies the parent telemetry scope for the telemetry signal", Mandatory = $false)]
     [string] $parentTelemetryScopeJson = '7b7d',
     [Parameter(HelpMessage = "Project folder", Mandatory = $false)]
-    [string] $project = ".",
-    [Parameter(HelpMessage = "Secrets from repository in compressed Json format", Mandatory = $false)]
-    [string] $secretsJson = '{"insiderSasToken":""}'
+    [string] $project = "."
 )
 
 $errorActionPreference = "Stop"; $ProgressPreference = "SilentlyContinue"; Set-StrictMode -Version 2.0
 $telemetryScope = $null
 $bcContainerHelperPath = $null
 
 # IMPORTANT: No code that can fail should be outside the try/catch
+# IMPORTANT: All actions needs a try/catch here and not only in the yaml file, else they can silently fail
 
 try {
     #region Action: Setup
@@ -22,40 +21,30 @@ try {
 
     #region Action: Determine artifacts to use
     $telemetryScope = CreateScope -eventId 'DO0084' -parentTelemetryScopeJson $parentTelemetryScopeJson
-    $secrets = $secretsJson | ConvertFrom-Json | ConvertTo-HashTable
-    if ($secrets.ContainsKey('insiderSasToken')) {
-        $insiderSasToken = [System.Text.Encoding]::UTF8.GetString([System.Convert]::FromBase64String($secrets.insiderSasToken))
-    } else {
-        $insiderSasToken = ""
-    }
-    $projectSettings = $env:Settings | ConvertFrom-Json | ConvertTo-HashTable
-    $projectSettings = AnalyzeRepo -settings $projectSettings -project $project -doNotCheckArtifactSetting -doNotIssueWarnings
-    $artifactUrl = Determine-ArtifactUrl -projectSettings $projectSettings -insiderSasToken $insiderSasToken
+    $secrets = $env:Secrets | ConvertFrom-Json | ConvertTo-HashTable
+    $insiderSasToken = [System.Text.Encoding]::UTF8.GetString([System.Convert]::FromBase64String($Secrets.insiderSasToken))
+    $settings = $env:Settings | ConvertFrom-Json | ConvertTo-HashTable
+    $settings = AnalyzeRepo -settings $settings -project $project -doNotCheckArtifactSetting -doNotCheckAppDependencyProbingPaths -doNotIssueWarnings
+    $artifactUrl = Determine-ArtifactUrl -projectSettings $settings -insiderSasToken $insiderSasToken
     $artifactCacheKey = ''
-    $projectSettings.artifact = $artifactUrl
-    if ($projectSettings.useCompilerFolder) {
+    if ($settings.useCompilerFolder) {
         $artifactCacheKey = $artifactUrl.Split('?')[0]
     }
     #endregion
 
     #region Action: Output
     # Set output variables
-    Write-Host "SETTINGS:"
-    $projectSettings | ConvertTo-Json -Depth 99 | Out-Host
-    Add-Content -Encoding UTF8 -Path $env:GITHUB_ENV -Value "Settings=$($projectSettings | ConvertTo-Json -Depth 99 -Compress)"
-
     Add-Content -Encoding UTF8 -Path $env:GITHUB_ENV -Value "artifact=$artifactUrl"
-    Write-Host "Artifact=$artifactUrl"
+    Write-Host "artifact=$artifactUrl"
     Add-Content -Encoding UTF8 -Path $env:GITHUB_ENV -Value "artifactCacheKey=$artifactCacheKey"
-    Write-Host "ArtifactCacheKey=$artifactCacheKey"
+    Write-Host "artifactCacheKey=$artifactCacheKey"
     #endregion
 
     TrackTrace -telemetryScope $telemetryScope
 }
 catch {
     OutputError -message "DetermineArtifactUrl action failed.$([environment]::Newline)Error: $($_.Exception.Message)$([environment]::Newline)Stacktrace: $($_.scriptStackTrace)"
     TrackException -telemetryScope $telemetryScope -errorRecord $_
-    exit
 }
 finally {
     CleanupAfterBcContainerHelper -bcContainerHelperPath $bcContainerHelperPath

Actions/DetermineArtifactUrl/README.md

@@ -7,19 +7,19 @@ Determines the artifactUrl to use for a given project
 | Name | Description |
 | :-- | :-- |
 | Settings | env.Settings must be set by a prior call to the ReadSettings Action |
+| Secrets | env.Secrets with insiderSasToken must be read by a prior call to the ReadSecrets Action |
 
 ### Parameters
 | Name | Required | Description | Default value |
 | :-- | :-: | :-- | :-- |
 | shell | | The shell (powershell or pwsh) in which the PowerShell script in this action should run | powershell |
 | parentTelemetryScopeJson | | Specifies the parent telemetry scope for the telemetry signal | {} |
 | project | | Project folder if repository is setup for multiple projects | . |
-| secretsJson | | Secrets from repository in compressed Json format | |
 
 ## OUTPUT
 
 ### ENV variables
 | Name | Description |
 | :-- | :-- |
-| ArtifactUrl | The ArtifactUrl to use |
-| ArtifactCacheKey | The Cache Key to use for caching the artifacts when using CompilerFolder |
+| artifact | The ArtifactUrl to use for the build |
+| artifactCacheKey | The Cache Key to use for caching the artifacts when using CompilerFolder |

Actions/DetermineArtifactUrl/action.yaml

@@ -13,10 +13,6 @@ inputs:
     description: Project folder
     required: false
     default: '.'
-  secretsJson:
-    description: Secrets from repository in compressed Json format
-    required: false
-    default: '{"insiderSasToken":""}'
 runs:
   using: composite
   steps:
@@ -25,8 +21,7 @@ runs:
       env:
         _parentTelemetryScopeJson: ${{ inputs.parentTelemetryScopeJson }}
         _project: ${{ inputs.project }}
-        _secretsJson: ${{ inputs.secretsJson }}
-      run: try { ${{ github.action_path }}/DetermineArtifactUrl.ps1 -parentTelemetryScopeJson $env:_parentTelemetryScopeJson -project $ENV:_project -secretsJson $ENV:_secretsJson } catch { Write-Host "::Error::Unexpected error when running action ($($_.Exception.Message.Replace("`r",'').Replace("`n",' ')))"; exit 1 }
+      run: try { ${{ github.action_path }}/DetermineArtifactUrl.ps1 -parentTelemetryScopeJson $env:_parentTelemetryScopeJson -project $ENV:_project } catch { Write-Host "::Error::Unexpected error when running action ($($_.Exception.Message.Replace("`r",'').Replace("`n",' ')))"; exit 1 }
 branding:
   icon: terminal
   color: blue

Actions/DetermineProjectsToBuild/DetermineProjectsToBuild.Action.ps1

@@ -15,6 +15,7 @@ $telemetryScope = $null
 $bcContainerHelperPath = $null
 
 # IMPORTANT: No code that can fail should be outside the try/catch
+# IMPORTANT: All actions needs a try/catch here and not only in the yaml file, else they can silently fail
 
 try {
     #region Action: Setup
@@ -23,11 +24,11 @@ try {
     Import-Module (Join-Path -Path $PSScriptRoot -ChildPath "..\TelemetryHelper.psm1" -Resolve) -DisableNameChecking
     #endregion
 
+    $telemetryScope = CreateScope -eventId 'DO0085' -parentTelemetryScopeJson $parentTelemetryScopeJson
+
     #region Action: Determine projects to build
     . (Join-Path -Path $PSScriptRoot -ChildPath "DetermineProjectsToBuild.ps1" -Resolve)
     $allProjects, $projectsToBuild, $projectDependencies, $buildOrder = Get-ProjectsToBuild -baseFolder $baseFolder -modifiedFiles $modifiedFiles -maxBuildDepth $maxBuildDepth
-
-    $telemetryScope = CreateScope -eventId 'DO0085' -parentTelemetryScopeJson $parentTelemetryScopeJson
     AddTelemetryProperty -telemetryScope $telemetryScope -key "projects" -value "$($allProjects -join ', ')"
     #endregion
 
@@ -51,7 +52,6 @@ try {
 catch {
     OutputError -message "DetermineProjectsToBuild action failed.$([environment]::Newline)Error: $($_.Exception.Message)$([environment]::Newline)Stacktrace: $($_.scriptStackTrace)"
     TrackException -telemetryScope $telemetryScope -errorRecord $_
-    exit
 }
 finally {
     CleanupAfterBcContainerHelper -bcContainerHelperPath $bcContainerHelperPath