Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource processor porter install logs are frequently truncated in log analytics #3992

Closed
jonnyry opened this issue Jun 21, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@jonnyry
Copy link
Collaborator

jonnyry commented Jun 21, 2024

When the resource processor installs a porter image, the logs include lengthy terraform which is often over the maximum field size for Log Analytics, resulting in truncated data.

If you're trying to determine why a component has failed to install, the error is generally at the bottom, hence its not helpful to have truncated output.

image

@jonnyry jonnyry added the bug Something isn't working label Jun 21, 2024
marrobi added a commit that referenced this issue Aug 1, 2024
Related to #3992

Modify the `shell_output_logger` function in `resource_processor/shared/logging.py` to split lengthy log outputs into smaller chunks before logging.

* **Chunk Log Output**:
  - Add `chunk_log_output` helper function to split the log output into smaller chunks.
  - Update `shell_output_logger` to use `chunk_log_output` for logging lengthy outputs in chunks.

* **Tests**:
  - Add `test_shell_output_logger_chunked_logging` to verify chunked logging functionality.
  - Add `test_chunk_log_output` to test the `chunk_log_output` helper function.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/AzureTRE/issues/3992?shareId=XXXX-XXXX-XXXX-XXXX).
@marrobi marrobi moved this to In Progress in Azure TRE - Engineering Oct 10, 2024
@marrobi
Copy link
Member

marrobi commented Nov 7, 2024

Closed in #4048

@marrobi marrobi closed this as completed Nov 7, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Azure TRE - Engineering Nov 7, 2024
@SamLennark SamLennark moved this from In Progress to Done in Azure TRE - Engineering Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants