Fix resource processor porter install logs truncation #4048
Conversation
Related to #3992 Modify the `shell_output_logger` function in `resource_processor/shared/logging.py` to split lengthy log outputs into smaller chunks before logging. * **Chunk Log Output**: - Add `chunk_log_output` helper function to split the log output into smaller chunks. - Update `shell_output_logger` to use `chunk_log_output` for logging lengthy outputs in chunks. * **Tests**: - Add `test_shell_output_logger_chunked_logging` to verify chunked logging functionality. - Add `test_chunk_log_output` to test the `chunk_log_output` helper function. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/AzureTRE/issues/3992?shareId=XXXX-XXXX-XXXX-XXXX).
|
@jonnyry another AI assisted fix, fancy testing? |
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 9dd6b9d. ♻️ This comment has been updated with latest results. |
* Change version from "0.9.0" to "0.9.1" --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/AzureTRE/issues/3992?shareId=XXXX-XXXX-XXXX-XXXX).
|
Update version number in
For more details, open the Copilot Workspace session. |
Sure will do thanks. |
|
@marrobi Looking good... :-) Can I suggest prefixing chunked log entries with [Log chunk X of Y] or similar for readability?
|
|
/test |
|
🤖 pr-bot 🤖 🏃 Running tests: https://github.com/microsoft/AzureTRE/actions/runs/11278144139 (with refid (in response to this comment from @marrobi) |
|
@jonnyry this better? |
Yes great thanks :-)
|
|
/test-force-approve Passed here - https://github.com/microsoft/AzureTRE/actions/runs/11278144139 |
|
🤖 pr-bot 🤖 ✅ Marking tests as complete (for commit 9dd6b9d) (in response to this comment from @marrobi) |
Related to #3992
Modify the
shell_output_loggerfunction inresource_processor/shared/logging.pyto split lengthy log outputs into smaller chunks before logging.Chunk Log Output:
chunk_log_outputhelper function to split the log output into smaller chunks.shell_output_loggerto usechunk_log_outputfor logging lengthy outputs in chunks.Tests:
test_shell_output_logger_chunked_loggingto verify chunked logging functionality.test_chunk_log_outputto test thechunk_log_outputhelper function.For more details, open the Copilot Workspace session.