Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ability to debug resource processor locally #3654

Merged
merged 9 commits into from
Aug 11, 2023

Conversation

marrobi
Copy link
Member

@marrobi marrobi commented Aug 4, 2023

Resolves #3426

What is being addressed

  • Since additional cloud support need Key Vault URI rather than name. Create an output and pass that through to RP.
  • VS Code remote containers extension means REMOTE_CONTAINERS_IPC need setting when running Porter in debug session
  • Add IP allow list to app insights for local debugging
  • Give RP SPN access to read Key Vault secrets when local debugging

To test, follow:

https://microsoft.github.io/AzureTRE/v0.12.0/tre-developers/resource-processor/

@github-actions
Copy link

github-actions bot commented Aug 4, 2023

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit f8f9256.

♻️ This comment has been updated with latest results.

@marrobi
Copy link
Member Author

marrobi commented Aug 5, 2023

/test-extended

@github-actions
Copy link

github-actions bot commented Aug 5, 2023

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/5769682608 (with refid 2eb403c7)

(in response to this comment from @marrobi)

@marrobi
Copy link
Member Author

marrobi commented Aug 11, 2023

/test-force-approve

Passed: https://github.com/microsoft/AzureTRE/actions/runs/5769682608

@github-actions
Copy link

🤖 pr-bot 🤖

✅ Marking tests as complete (for commit f8f9256)

(in response to this comment from @marrobi)

@marrobi marrobi enabled auto-merge (squash) August 11, 2023 12:59
Copy link
Collaborator

@SvenAelterman SvenAelterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marrobi marrobi merged commit ffccc84 into microsoft:main Aug 11, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants