Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output is_exposed_externally, for all resources with URI #3656

Merged
merged 7 commits into from
Oct 3, 2023
Merged

Output is_exposed_externally, for all resources with URI #3656

merged 7 commits into from
Oct 3, 2023

Conversation

marrobi
Copy link
Member

@marrobi marrobi commented Aug 7, 2023 •
edited
Loading

Resolves #3584

How is this addressed

  • add is_exposed_externally to restricted resource model
  • Add is_exposed_externally with defaults for all resources with URIs

image

@github-actions
Copy link

github-actions bot commented Aug 7, 2023 •
edited
Loading

Unit Test Results

576 tests   576 ✔️  14s ⏱️
    1 suites      0 💤
    1 files        0 ❌

Results for commit 95e9ee1.

♻️ This comment has been updated with latest results.

@marrobi marrobi marked this pull request as ready for review August 14, 2023 07:56
@marrobi marrobi enabled auto-merge (squash) September 20, 2023 12:27
@marrobi marrobi mentioned this pull request Sep 20, 2023
Merged
@tamirkamara
Copy link
Collaborator

What is this for?

@marrobi
Copy link
Member Author

marrobi commented Sep 21, 2023

What is this for?

Functionality was added to the UI to enable users to copy and paste a URI toa private resource. This relies on is_exposed_externally, As this isn't exposed for restricted view of a resource a connect button would go, and try access the URI over the internet hence give a 403. The PR exposes is_exposed_externally and applies it consistently across all templates with URIs.

@marrobi
Copy link
Member Author

marrobi commented Sep 21, 2023

/test-shared-services

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running shared service tests: https://github.com/microsoft/AzureTRE/actions/runs/6258646466 (with refid d71ad0d8)

(in response to this comment from @marrobi)

@marrobi
Copy link
Member Author

marrobi commented Sep 22, 2023

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/6276011634 (with refid d71ad0d8)

(in response to this comment from @marrobi)

@marrobi
Copy link
Member Author

marrobi commented Sep 25, 2023

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/6301202063 (with refid d71ad0d8)

(in response to this comment from @marrobi)

martinpeck
martinpeck reviewed Sep 27, 2023
View reviewed changes
Copy link
Member

@martinpeck martinpeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made one comment, then realised I don't really understand what this does so can't really give you much additional input. Soz.

api_app/models/domain/restricted_resource.py Show resolved Hide resolved
@marrobi marrobi merged commit 1143f2a into microsoft:main Oct 3, 2023
10 checks passed
@marrobi marrobi deleted the marrobi/issue3584 branch October 3, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinpeck martinpeck martinpeck left review comments

@jjgriff93 jjgriff93 jjgriff93 approved these changes

@tamirkamara tamirkamara Awaiting requested review from tamirkamara

@SvenAelterman SvenAelterman Awaiting requested review from SvenAelterman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Copy URL for internal services does not work for shared services
4 participants
@marrobi @tamirkamara @martinpeck @jjgriff93