-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
terraform_typed_variables turn on #3660
Conversation
@microsoft-github-policy-service agree |
@nayeem01 thanks for the contribution. You have turned the linter on, but you will also need to add the types into variable files where they are missing. |
@marrobi Hello, I have added the missing types in variable files. However, I am not sure about some variable types. Please check and let me know your feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial pass, will have to run the full set of tests to ensure all are correct.
...ace_services/guacamole/user_resources/guacamole-azure-export-reviewvm/terraform/variables.tf
Outdated
Show resolved
Hide resolved
...ace_services/guacamole/user_resources/guacamole-azure-import-reviewvm/terraform/variables.tf
Show resolved
Hide resolved
...s/workspace_services/guacamole/user_resources/guacamole-azure-linuxvm/terraform/variables.tf
Show resolved
Hide resolved
/test-extended abc99a5 |
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/5830418158 (with refid (in response to this comment from @marrobi) |
/test-destroy-env |
Destroying PR test environment (RG: rg-treaf207fb6)... (run: https://github.com/microsoft/AzureTRE/actions/runs/5831384476) |
PR test environment destroy complete (RG: rg-treaf207fb6) |
/test-extended |
🤖 pr-bot 🤖
(in response to this comment from @marrobi) |
/test-extended abc99a5 |
🤖 pr-bot 🤖
(in response to this comment from @marrobi) |
/test-extended 8bf9b07 |
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/5831773426 (with refid (in response to this comment from @marrobi) |
/test-extended |
🤖 pr-bot 🤖
(in response to this comment from @marrobi) |
/test-extended f6dc161 |
🤖 pr-bot 🤖 🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/5853266548 (with refid (in response to this comment from @marrobi) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you very much for your contribution.
We will need to check all the workspace services deploy prior to the next release.
Resolves #3657
Hello, I have made some changes to this issue. Please check if it is correct or not.