Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform_typed_variables turn on #3660

Merged
merged 13 commits into from
Aug 14, 2023
Merged

terraform_typed_variables turn on #3660

merged 13 commits into from
Aug 14, 2023

Conversation

nayeem01
Copy link
Contributor

@nayeem01 nayeem01 commented Aug 8, 2023

Resolves #3657

Hello, I have made some changes to this issue. Please check if it is correct or not.

@github-actions github-actions bot added the external PR from an external contributor label Aug 8, 2023
@nayeem01
Copy link
Contributor Author

nayeem01 commented Aug 8, 2023

@microsoft-github-policy-service agree

@marrobi
Copy link
Member

marrobi commented Aug 8, 2023

@nayeem01 thanks for the contribution. You have turned the linter on, but you will also need to add the types into variable files where they are missing.

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit f6dc161.

♻️ This comment has been updated with latest results.

@nayeem01
Copy link
Contributor Author

nayeem01 commented Aug 9, 2023

@marrobi Hello, I have added the missing types in variable files. However, I am not sure about some variable types. Please check and let me know your feedback.

Copy link
Member

@marrobi marrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial pass, will have to run the full set of tests to ensure all are correct.

.github/linters/.tflint_shared_services.hcl Outdated Show resolved Hide resolved
.github/linters/.tflint_user_resources.hcl Outdated Show resolved Hide resolved
.github/linters/.tflint_workspace_services.hcl Outdated Show resolved Hide resolved
.github/linters/.tflint_workspaces.hcl Outdated Show resolved Hide resolved
@marrobi
Copy link
Member

marrobi commented Aug 11, 2023

/test-extended abc99a5

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/5830418158 (with refid af207fb6)

(in response to this comment from @marrobi)

@marrobi
Copy link
Member

marrobi commented Aug 11, 2023

/test-destroy-env

@github-actions
Copy link

Destroying PR test environment (RG: rg-treaf207fb6)... (run: https://github.com/microsoft/AzureTRE/actions/runs/5831384476)

@github-actions
Copy link

PR test environment destroy complete (RG: rg-treaf207fb6)

@marrobi
Copy link
Member

marrobi commented Aug 11, 2023

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

⚠️ When using /test-extended on external PRs, the SHA of the checked commit must be specified

(in response to this comment from @marrobi)

@marrobi
Copy link
Member

marrobi commented Aug 11, 2023

/test-extended abc99a5

@github-actions
Copy link

🤖 pr-bot 🤖

⚠️ The specified SHA abc99a5 is not the latest commit on the PR. Please validate the latest commit and re-run /test

(in response to this comment from @marrobi)

@marrobi
Copy link
Member

marrobi commented Aug 11, 2023

/test-extended 8bf9b07

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/5831773426 (with refid af207fb6)

(in response to this comment from @marrobi)

@marrobi
Copy link
Member

marrobi commented Aug 14, 2023

/test-extended

@github-actions
Copy link

🤖 pr-bot 🤖

⚠️ When using /test-extended on external PRs, the SHA of the checked commit must be specified

(in response to this comment from @marrobi)

@marrobi
Copy link
Member

marrobi commented Aug 14, 2023

/test-extended f6dc161

@github-actions
Copy link

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/5853266548 (with refid af207fb6)

(in response to this comment from @marrobi)

Copy link
Member

@marrobi marrobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you very much for your contribution.

We will need to check all the workspace services deploy prior to the next release.

@marrobi marrobi merged commit c3f144f into microsoft:main Aug 14, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external PR from an external contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assign types to all vars and turn on the TFLint rule that validates it.
3 participants