Update KeyVault references

[marrobi]

Fixes #4110 #2463

This pull request updates the references to KeyVault secrets in the code. The AAD_TENANT_ID, API_CLIENT_ID, and API_CLIENT_SECRET references are now constructed using the version so terraform cascades the update.

[github-actions]

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 5011793.

♻️ This comment has been updated with latest results.

[marrobi]

/test-extended

[github-actions]

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/11498586135 (with refid 9655aa5d)

(in response to this comment from @marrobi)

[tamirkamara]

What does it mean that it cascades the update?

[marrobi]

now constructed using the version so terraform cascades the update.

So that it updates the API app configuration values when the key vault secret version is updates. It seems that terraform doesn't always update the reference.

As per issue discussion see - hashicorp/terraform-provider-azurerm#3129 (comment)

[tim-allen-ck]

LGTM

[yuvalyaron]

/test-extended

[github-actions]

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/11704066429 (with refid 9655aa5d)

(in response to this comment from @yuvalyaron)

[marrobi]

/test-extended

[github-actions]

🤖 pr-bot 🤖

🏃 Running extended tests: https://github.com/microsoft/AzureTRE/actions/runs/11708350316 (with refid 9655aa5d)

(in response to this comment from @marrobi)