-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable storage account infrastructure encryption #4139
base: main
Are you sure you want to change the base?
Enable storage account infrastructure encryption #4139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Unit Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 522aaa7. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a CMK contribution coming in too. Are the two compatible with each other?
@yuvalyaron
@tamirkamara yes, they are compatible |
Resolves #4001
What is being addressed
Enable storage account infrastructure encryption.
Since storage account infrastructure encryption can only be turned on when a storage account is first created (unless you allow terraform to destroy the storage account and recreate it), this change is only applied on first deployment of a TRE (or a template component). Storage accounts that exist within an existing TRE deployment will not be affected.
The terraform pattern used to acheive this behaviour is as follows: