Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update package.json to include the repository #8747

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

v-jiepeng
Copy link
Member

@v-jiepeng v-jiepeng commented Oct 20, 2021

#minor

Hi there!
This change adds the repository property to your package.json file(s). Having this available provides a number of benefits to security tooling. For example, it allows for greater trust by checking for signed commits, contributors to a release and validating history with the project. It also allows for comparison between the source code and the published artifact in order to detect attacks on authors during the publication process.
We validate that we're making a PR against the correct repository by comparing the metadata for the published artifact on npmjs.com against the metadata in the package.json file in the repository.
This change is provided by a team at Microsoft -- we're happy to answer any questions you may have. (Members of this team include @s-tuli, @iarna, @v-rr, @v-jiepeng, @v-zhzhou and @v-gjy). If you would prefer that we not make these sorts of PRs to projects you maintain, please just say. If you'd like to learn more about what we're doing here, we've prepared a document talking about both this project and some of our other activities around supply chain security here: microsoft/Secure-Supply-Chain
This PR provides repository metadata for the following packages:

  • @bfc/adaptive-flow
  • @bfc/adaptive-form
  • @bfc/client
  • @bfc/electron-server
  • @bfc/extension
  • @bfc/extension-client
  • @bfc/form-dialogs
  • @bfc/integration-tests
  • @bfc/intellisense
  • @bfc/eslint-plugin-bfcomposer
  • @bfc/ui-shared
  • @bfc/server
  • @bfc/server-workers
  • @botframework-composer/test-utils
  • @bfc/built-in-functions
  • @bfc/intellisense-languageserver
  • @bfc/lg-languageserver
  • @bfc/lu-languageserver
  • @botframework-composer/types
  • @bfc/ui-plugin-composer
  • @bfc/ui-plugin-cross-trained
  • plugin-name
  • @bfc/ui-plugin-lg
  • @bfc/ui-plugin-luis
  • @bfc/ui-plugin-orchestrator
  • @bfc/ui-plugin-prompts
  • @bfc/ui-plugin-dialog-schema-editor
  • @bfc/ui-plugin-select-dialog
  • @bfc/ui-plugin-select-skill-dialog

Description

Task Item

Screenshots

Hi there!
This change adds the repository property to your package.json file(s). Having this available provides a number of benefits to security tooling. For example, it allows for greater trust by checking for signed commits, contributors to a release and validating history with the project. It also allows for comparison between the source code and the published artifact in order to detect attacks on authors during the publication process.
We validate that we're making a PR against the correct repository by comparing the metadata for the published artifact on [npmjs.com](www.npmjs.com) against the metadata in the package.json file in the repository.
This change is provided by a team at Microsoft -- we're happy to answer any questions you may have. (Members of this team include [@s-tuli](https://github.com/s-tuli), [@iarna](https://github.com/iarna), [@v-rr](https://github.com/v-rr), [@v-jiepeng](https://github.com/v-jiepeng), [@v-zhzhou](https://github.com/v-zhzhou) and [@v-gjy](https://github.com/v-gjy)). If you would prefer that we not make these sorts of PRs to projects you maintain, please just say. If you'd like to learn more about what we're doing here, we've prepared a document talking about both this project and some of our other activities around supply chain security here: [microsoft/Secure-Supply-Chain](https://github.com/microsoft/Secure-Supply-Chain)
This PR provides repository metadata for the following packages:
* @bfc/adaptive-flow
* @bfc/adaptive-form
* @bfc/client
* @bfc/electron-server
* @bfc/extension
* @bfc/extension-client
* @bfc/form-dialogs
* @bfc/integration-tests
* @bfc/intellisense
* @bfc/eslint-plugin-bfcomposer
* @bfc/ui-shared
* @bfc/server
* @bfc/server-workers
* @botframework-composer/test-utils
* @bfc/built-in-functions
* @bfc/intellisense-languageserver
* @bfc/lg-languageserver
* @bfc/lu-languageserver
* @botframework-composer/types
* @bfc/ui-plugin-composer
* @bfc/ui-plugin-cross-trained
* plugin-name
* @bfc/ui-plugin-lg
* @bfc/ui-plugin-luis
* @bfc/ui-plugin-orchestrator
* @bfc/ui-plugin-prompts
* @bfc/ui-plugin-dialog-schema-editor
* @bfc/ui-plugin-select-dialog
* @bfc/ui-plugin-select-skill-dialog
@ghost
Copy link

ghost commented Oct 20, 2021

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ v-jiepeng sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@coveralls
Copy link

coveralls commented Oct 20, 2021

Coverage Status

Coverage remained the same at 55.954% when pulling cbb4711 on v-jiepeng:patch-1 into f5208f0 on microsoft:main.

@v-jiepeng
Copy link
Member Author

Is there anything that is needed to land this pull request ?

@cwhitten
Copy link
Member

@v-jiepeng it doesn't look like you have signed the Microsoft Contributor License Agreement.

@cwhitten cwhitten changed the title Update package.json to include the repository chore: Update package.json to include the repository Jan 10, 2022
@BruceHaley
Copy link
Contributor

@dependabot rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants