Set shuffle=True by default in data_sampler #6531
Open
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree company="Intel" |
loadams
approved these changes
Sep 13, 2024
tohtana
approved these changes
Oct 8, 2024
loadams
added a commit
that referenced
this pull request
Nov 4, 2024
|
@ranzhejiang - we've fixed a number of issues with our CI, but we are still seeing this one timeout even after merging the fixes in. Do you have any ideas why this might be? The tests that rely on this shouldn't hang with this change. |
I also feel confused about this hang problem, I will test it for my local machine to check it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
shuffle=Trueby default in data_sampler, the discuss is in #5619