Flops profiler support einops.einsum #6755
Open
+35
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvhoaa
commented
Nov 17, 2024
lvhoaa
commented
- Added support for FlopsProfiler to include einops.einsum operation
- Added _patch_miscellaneous_operations() and _reload_miscellaneous_operations() to include this operation and potentially include other miscellaneous operations in the future
- Added _einops_einsum_flops_compute() that mimic already-existed _einsum_flops_compute()
|
@microsoft-github-policy-service agree |
loadams
reviewed
Nov 18, 2024
| @@ -16,6 +16,8 @@ | |||
| from deepspeed.moe.layer import MoE | |||
| from deepspeed.utils.timer import FORWARD_GLOBAL_TIMER, BACKWARD_GLOBAL_TIMER, STEP_GLOBAL_TIMER | |||
| from deepspeed.utils.torch import required_torch_version | |||
| import einops | |||
There was a problem hiding this comment.
Hi @lvhoaa - could you run the pre-commit formatter on the branch to ensure the formatting check passes?
Also einops is not included in the requirements file, so it will need to be added there otherwise the tests will fail.
There was a problem hiding this comment.
@loadams Thanks for the feedback! I have pushed a fix!
loadams
reviewed
Nov 19, 2024
bin/deepspeed
Outdated
loadams
reviewed
Nov 19, 2024
requirements/requirements.txt
Outdated
| @@ -1,3 +1,4 @@ | |||
| einops | |||
There was a problem hiding this comment.
I believe this would probably be better suited to the requirements-dev file
…com/lvhoaa/DeepSpeed into FlopsProfiler-support-einops.einsum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.