Enable some tests on non-Windows (#5549)

These tests all build and pass on non-Windows platforms, so we should run them there too.
microsoft · Aug 15, 2023 · 15d086f · 15d086f
1 parent 756125c
commit 15d086f
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 10 deletions.
diff --git a/tools/clang/unittests/HLSL/DxilContainerTest.cpp b/tools/clang/unittests/HLSL/DxilContainerTest.cpp
@@ -604,7 +604,6 @@ bool DxilContainerTest::InitSupport() {
   return true;
 }
 
-#ifdef _WIN32 // - No reflection support
 TEST_F(DxilContainerTest, CompileWhenDebugSourceThenSourceMatters) {
   char program1[] = "float4 main() : SV_Target { return 0; }";
   char program2[] = "  float4 main() : SV_Target { return 0; }  ";
@@ -661,7 +660,6 @@ TEST_F(DxilContainerTest, CompileWhenDebugSourceThenSourceMatters) {
   // Source hash and bin hash should be different
   VERIFY_IS_FALSE(0 == strcmp(binHash1Zss.c_str(), binHash1.c_str()));
 }
-#endif // WIN32 - No reflection support
 
 TEST_F(DxilContainerTest, ContainerBuilder_AddPrivateForceLast) {
   if (m_ver.SkipDxilVersion(1, 7)) return;

diff --git a/tools/clang/unittests/HLSL/FunctionTest.cpp b/tools/clang/unittests/HLSL/FunctionTest.cpp
@@ -99,7 +99,6 @@ class FunctionTest : public ::testing::Test {
       CComPtr<IDxcBlob> pContainer;
 
       VERIFY_SUCCEEDED(pResult->GetResult(&pContainer));
-#ifdef _WIN32 // No reflection support
       VERIFY_SUCCEEDED(m_support.CreateInstance(CLSID_DxcContainerReflection, &pReflection));
       VERIFY_SUCCEEDED(pReflection->Load(pContainer));
       UINT count;
@@ -114,7 +113,6 @@ class FunctionTest : public ::testing::Test {
         }
       }
       VERIFY_IS_TRUE(found);
-#endif // _WIN32 - No reflection support
     }
   }
 

diff --git a/tools/clang/unittests/HLSLTestLib/FileCheckerTest.cpp b/tools/clang/unittests/HLSLTestLib/FileCheckerTest.cpp
@@ -115,13 +115,7 @@ FileRunCommandResult FileRunCommandPart::Run(dxc::DxcDllSupport &DllSupport, con
     return RunDxr(DllSupport, Prior);
   }
   else if (0 == _stricmp(Command.c_str(), "%dxl")) {
-#ifdef _WIN32 // Linking unsupported
     return RunLink(DllSupport, Prior);
-#else
-    FileRunCommandResult result = FileRunCommandResult::Success("Can't run dxl on non-windows, so just assuming success");
-    result.AbortPipeline = true;
-    return result;
-#endif // WIN32 - Linking unsupported
   }
   else if (pPluginToolsPaths != nullptr) {
     auto it = pPluginToolsPaths->find(Command.c_str());