Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++17] Merge upsteam change for Don't use std::iterator in PATH.h #5483

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

python3kgae
Copy link
Contributor

@python3kgae python3kgae commented Aug 1, 2023

Merge upstream change
llvm/llvm-project@91c8daf

In converting this over to iterator_facade_base, some member
operators and methods are no longer needed since iterator_facade
implements them in the base class using CRTP.

This is part of enable C++17.

Copy link
Member

@pow2clk pow2clk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine. I would like the description from the original change to be included.

@python3kgae python3kgae merged commit a5b0488 into microsoft:main Aug 2, 2023
12 checks passed
@python3kgae python3kgae deleted the support_17 branch August 2, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants