[SPIR-V] Implement SpirvType and SpirvOpaqueType #6156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-perron
approved these changes
Jan 18, 2024
s-perron
requested changes
Jan 18, 2024
There was a problem hiding this comment.
Generally look okay to me. I have a request for a few extra comments, and if you can split out the ConstEvaluator refactor into a separate PR, that would be nice.
Also @llvm-beanz should look at this as well (or someone else for MS) since you are making significant chagnes to SEMA.
cassiebeckley
added a commit
to cassiebeckley/DirectXShaderCompiler
that referenced
this pull request
Jan 24, 2024
This refactor is split out from microsoft#6156, which needs to use these methods in LowerTypeVisitor.
cassiebeckley
force-pushed
the
spirv-type-intrinsic
branch
from
2155592
to
503e09e
Compare
Keenuts
pushed a commit
that referenced
this pull request
Jan 29, 2024
This moves functions for evaluating constant expressions and translating LLVM AP types to SPIR-V constants into a new class. These functions need to be used from LowerTypeVisitor in #6156, so I am factoring them out to avoid duplication.
Implements hlsl-specs proposal 0011, adding `vk::SpirvType` and `vk::SpirvOpaqueType` templates which allow users to define and use SPIR-V level types.
cassiebeckley
force-pushed
the
spirv-type-intrinsic
branch
from
503e09e
to
83cd745
Compare
s-perron
approved these changes
Jan 29, 2024
sudonatalie
approved these changes
Jan 29, 2024
llvm-beanz
reviewed
Feb 7, 2024
…o spirv-type-intrinsic
…o spirv-type-intrinsic
…o spirv-type-intrinsic
|
@sudonatalie @llvm-beanz I've updated this PR based on the design changes to 0011. |
sudonatalie
reviewed
Apr 2, 2024
|
LGTM @llvm-beanz Can you take another look? |
llvm-beanz
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements hlsl-specs proposal 0011, adding
vk::SpirvTypeandvk::SpirvOpaqueTypetemplates which allow users to define and use SPIR-V level types.