Fix -link -Qstrip_debug failing #6833
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi - thank you for your contribution and apologies for the delay in responding to this. We do ask that all changes and fixes like this are accompanied with tests that validate the fix. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5737
Link doesn't include the ILDB chunk in the first place when -Qstrip_debug is used, so this fixes it failing in UpdatePart.
The compiler does the same thing, sort of, except the compiler's default behavior is different (it doesn't embed debug by default), so this omits the condition to reflect that.
This will cause -Fd -Qstrip_debug to fail, but -Fd -Qstrip_debug doesn't work properly anyway due to #5739 (which will be fixed in a separate forthcoming PR that doesn't conflict with this one)