Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop 2021 release wave2 #1235

Open
wants to merge 1 commit into
base: develop-2021ReleaseWave2
Choose a base branch
from

Conversation

jkanschik
Copy link

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (updates to documentation, formatting, etc.)

Description

This pull requests changes the Grid handling to accomodate for changes in ReleaseWave2.

Issues addressed

Fixes issue #1216
Also relates to #1229

All submissions:

  • My code follows the code style of this project.
  • Do existing samples that are effected by this change still run?
  • I have added samples for new functionality.
  • I raise detailed error messages when possible.
  • My code does not rely on labels that have the option to be hidden.

Which browsers was this tested on?

  • Chrome
  • Firefox
  • IE
  • Edge

@ghost
Copy link

ghost commented Nov 8, 2021

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ jkanschik sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

@jkanschik jkanschik changed the base branch from develop to develop-2021ReleaseWave2 November 8, 2021 16:00
@adambarath
Copy link

Any update on this? @jkanschik @AmarSinghMSFT @ronigam

@Shakevg
Copy link
Contributor

Shakevg commented Mar 29, 2024

jkanschik Please fix merge conflicts or cancel if it is not actual

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants