added more parameter alias coverage on R package

microsoft · Oct 24, 2019 · 2128ece · 2128ece
1 parent e48cdf3
commit 2128ece
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 4 deletions.
diff --git a/R-package/R/aliases.R b/R-package/R/aliases.R
@@ -8,8 +8,18 @@
 .PARAMETER_ALIASES <- function(){
     return(list(
         "boosting" = c(
-            "boosting_type"
+            "boosting"
             , "boost"
+            , "boosting_type"
+        )
+        , "metric" = c(
+            "metric"
+            , "metrics"
+            , "metric_types"
+        )
+        , "num_class" = c(
+            "num_class"
+            , "num_classes"
         )
     ))
 }
diff --git a/R-package/R/callback.R b/R-package/R/callback.R
@@ -38,9 +38,8 @@ cb.reset.parameters <- function(new_params) {
     # Some parameters are not allowed to be changed,
     # since changing them would simply wreck some chaos
     not_allowed <- c(
-      "num_class"
-      , "metric"
-      , "boosting"
+      .PARAMETER_ALIASES()[["num_class"]]
+      , .PARAMETER_ALIASES()[["metric"]]
       , .PARAMETER_ALIASES()[["boosting"]]
     )
     if (any(pnames %in% not_allowed)) {

diff --git a/R-package/tests/testthat/test_parameters.R b/R-package/tests/testthat/test_parameters.R
@@ -45,6 +45,9 @@ expect_true(".PARAMETER_ALIASES() returns a named list", {
   param_aliases <- .PARAMETER_ALIASES()
   expect_true(is.list(param_aliases))
   expect_true(is.character(names(param_aliases)))
+  expect_true(is.character(param_aliases[["boosting"]]))
+  expect_true(is.character(param_aliases[["metric"]]))
+  expect_true(is.character(param_aliases[["num_class"]]))
 })
 
 expect_true("training should warn if you use 'dart' boosting, specified with 'boosting' or aliases", {