minor fixes

microsoft · Mar 25, 2020 · 248d36d · 248d36d
1 parent e54954a
commit 248d36d
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 5 deletions.
diff --git a/.appveyor.yml b/.appveyor.yml
@@ -16,9 +16,6 @@ environment:
     - COMPILER: MINGW
       TASK: r-package
       R_WINDOWS_VERSION: 3.6.3
-    - COMPILER: MSVC
-      TASK: r-package
-      R_WINDOWS_VERSION: 3.6.3
 
 clone_depth: 5
 

diff --git a/.ci/test_r_package_windows.ps1 b/.ci/test_r_package_windows.ps1
@@ -83,4 +83,5 @@ if (Get-Content "$LOG_FILE_NAME" | Select-String -Pattern "WARNING" -Quiet) {
     Check-Output $False
 }
 
+Write-Output "No issues were found checking the R package"
 Exit 0
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -310,10 +310,8 @@ endif()
 if(BUILD_FOR_R)
   if(MSVC)
     # https://docs.microsoft.com/en-us/cpp/build/reference/link-input-files?redirectedfrom=MSDN&view=vs-2019
-    TARGET_LINK_LIBRARIES(lightgbm ${CMAKE_CURRENT_BINARY_DIR}/R.lib)
     TARGET_LINK_LIBRARIES(_lightgbm ${CMAKE_CURRENT_BINARY_DIR}/R.lib)
   else()
-    TARGET_LINK_LIBRARIES(lightgbm ${LIBR_CORE_LIBRARY})
     TARGET_LINK_LIBRARIES(_lightgbm ${LIBR_CORE_LIBRARY})
   endif()
 endif(BUILD_FOR_R)
-Original file line number
+Diff line change
@@ Expand Up @@
         Check-Output $False
     }
+    Write-Output "No issues were found checking the R package"
     Exit 0