Skip to content

Commit

Permalink
[R-package] correctly quote paths on Windows for CMake-based builds (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
jameslamb authored Nov 29, 2022
1 parent ed1771c commit 51efd90
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions build_r.R
Original file line number Diff line number Diff line change
Expand Up @@ -100,17 +100,18 @@ if (length(keyword_args) > 0L) {
for (i in seq_len(length(keyword_args))) {
arg_name <- names(keyword_args)[[i]]
define_name <- ARGS_TO_DEFINES[[arg_name]]
arg_value <- shQuote(keyword_args[[arg_name]])
arg_value <- shQuote(normalizePath(keyword_args[[arg_name]], winslash = "/"))
cmake_args_to_add <- c(cmake_args_to_add, paste0(define_name, "=", arg_value))
}
install_libs_content <- gsub(
pattern = paste0("command_line_args <- NULL")
, replacement = paste0(
"command_line_args <- c(\""
, paste(cmake_args_to_add, collapse = "\", \"")
, "\")"
"command_line_args <- c(\'"
, paste(cmake_args_to_add, collapse = "', '")
, "')"
)
, x = install_libs_content
, fixed = TRUE
)
}

Expand Down

0 comments on commit 51efd90

Please sign in to comment.