[ci] fix CMakeLint linelength errors (#4796)

* Update Sanitizer.cmake * Update FindLibR.cmake * Update IntegratedOpenCL.cmake * Update FindLibR.cmake * Update CMakeLists.txt * Update FindLibR.cmake * Update static_analysis.yml * Update CMakeLists.txt * Update FindLibR.cmake * Update IntegratedOpenCL.cmake * Update static_analysis.yml
microsoft · Nov 13, 2021 · 5b58733 · 5b58733
1 parent c3ff187
commit 5b58733
Show file tree

Hide file tree

Showing 4 changed files with 232 additions and 85 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -7,9 +7,14 @@ OPTION(USE_TIMETAG "Set to ON to output time costs" OFF)
 OPTION(USE_CUDA "Enable CUDA-accelerated training (EXPERIMENTAL)" OFF)
 OPTION(USE_DEBUG "Set to ON for Debug mode" OFF)
 OPTION(USE_SANITIZER "Use santizer flags" OFF)
-SET(ENABLED_SANITIZERS "address" "leak" "undefined" CACHE STRING
-  "Semicolon separated list of sanitizer names. E.g 'address;leak'. Supported sanitizers are
-address, leak, undefined and thread.")
+SET(
+  ENABLED_SANITIZERS
+  "address" "leak" "undefined"
+  CACHE
+  STRING
+  "Semicolon separated list of sanitizer names, e.g., 'address;leak'. \
+Supported sanitizers are address, leak, undefined and thread."
+)
 OPTION(BUILD_CPP_TEST "Build C++ tests with Google Test" OFF)
 OPTION(BUILD_STATIC_LIB "Build static library" OFF)
 OPTION(__BUILD_FOR_R "Set to ON if building lib_lightgbm for use with the R package" OFF)
@@ -63,7 +68,10 @@ elseif(CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang")
   cmake_minimum_required(VERSION 3.16)
 elseif(MSVC)
   if(MSVC_VERSION LESS 1900)
-    message(FATAL_ERROR "The compiler ${CMAKE_CXX_COMPILER} doesn't support required C++11 features. Please use a newer MSVC.")
+    message(
+      FATAL_ERROR
+      "The compiler ${CMAKE_CXX_COMPILER} doesn't support required C++11 features. Please use a newer MSVC."
+    )
   endif()
   cmake_minimum_required(VERSION 3.8)
 endif()
@@ -197,17 +205,20 @@ if(USE_CUDA)
       set(CMAKE_CUDA_STANDARD_REQUIRED ON)
     endif()
 
-    set(BASE_DEFINES
-     -DPOWER_FEATURE_WORKGROUPS=12
-     -DUSE_CONSTANT_BUF=0
+    set(
+      BASE_DEFINES
+      -DPOWER_FEATURE_WORKGROUPS=12
+      -DUSE_CONSTANT_BUF=0
     )
-    set(ALLFEATS_DEFINES
-     ${BASE_DEFINES}
-     -DENABLE_ALL_FEATURES
+    set(
+      ALLFEATS_DEFINES
+      ${BASE_DEFINES}
+      -DENABLE_ALL_FEATURES
     )
-    set(FULLDATA_DEFINES
-     ${ALLFEATS_DEFINES}
-     -DIGNORE_INDICES
+    set(
+      FULLDATA_DEFINES
+      ${ALLFEATS_DEFINES}
+      -DIGNORE_INDICES
     )
 
     message(STATUS "ALLFEATS_DEFINES: ${ALLFEATS_DEFINES}")
@@ -222,7 +233,8 @@ if(USE_CUDA)
         set(histograms ${histograms} PARENT_SCOPE)
       endif()
       target_compile_definitions(
-        histo${hsize}${hname} PRIVATE
+        histo${hsize}${hname}
+        PRIVATE
         -DCONST_HESSIAN=${hconst}
         ${hdir}
       )
@@ -278,29 +290,33 @@ if(${MM_MALLOC})
 endif()
 
 if(UNIX OR MINGW OR CYGWIN)
-    SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11 -pthread -Wextra -Wall -Wno-ignored-attributes -Wno-unknown-pragmas -Wno-return-type")
-    if(USE_DEBUG)
-        SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -g -O0")
-    else()
-        SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -O3")
-    endif()
-    if(USE_SWIG)
-        SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-strict-aliasing")
-    endif()
-    if(NOT USE_OPENMP)
-        SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-unknown-pragmas -Wno-unused-private-field")
-    endif()
-    if(__BUILD_FOR_R AND CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
-        SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-cast-function-type")
-    endif()
+  SET(
+    CMAKE_CXX_FLAGS
+    "${CMAKE_CXX_FLAGS} -std=c++11 -pthread -Wextra -Wall -Wno-ignored-attributes -Wno-unknown-pragmas -Wno-return-type"
+  )
+  if(USE_DEBUG)
+      SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -g -O0")
+  else()
+      SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -O3")
+  endif()
+  if(USE_SWIG)
+      SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-strict-aliasing")
+  endif()
+  if(NOT USE_OPENMP)
+      SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-unknown-pragmas -Wno-unused-private-field")
+  endif()
+  if(__BUILD_FOR_R AND CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
+      SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-cast-function-type")
+  endif()
 endif()
 
 if(WIN32 AND MINGW)
     SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -static-libstdc++")
 endif()
 
 if(MSVC)
-    SET(variables
+    SET(
+      variables
         CMAKE_C_FLAGS_DEBUG
         CMAKE_C_FLAGS_MINSIZEREL
         CMAKE_C_FLAGS_RELEASE
@@ -344,15 +360,17 @@ if(USE_MPI)
   include_directories(${MPI_CXX_INCLUDE_PATH})
 endif()
 
-file(GLOB SOURCES
-    src/boosting/*.cpp
-    src/io/*.cpp
-    src/metric/*.cpp
-    src/objective/*.cpp
-    src/network/*.cpp
-    src/treelearner/*.cpp
+file(
+    GLOB
+    SOURCES
+      src/boosting/*.cpp
+      src/io/*.cpp
+      src/metric/*.cpp
+      src/objective/*.cpp
+      src/network/*.cpp
+      src/treelearner/*.cpp
 if(USE_CUDA)
-    src/treelearner/*.cu
+      src/treelearner/*.cu
 endif()
 )
 
@@ -375,7 +393,7 @@ if(BUILD_STATIC_LIB)
 else()
   add_library(_lightgbm SHARED)
 endif()
-# LightGBM headers include openmp, cuda, R etc. headers, 
+# LightGBM headers include openmp, cuda, R etc. headers,
 # thus PUBLIC is required for building _lightgbm_swig target.
 target_link_libraries(_lightgbm PUBLIC lightgbm_capi_objs lightgbm_objs)
 
@@ -395,28 +413,53 @@ if(USE_SWIG)
   set_target_properties(_lightgbm_swig PROPERTIES OUTPUT_NAME "lib_lightgbm_swig")
   if(WIN32)
     if(MINGW OR CYGWIN)
-        add_custom_command(TARGET _lightgbm_swig POST_BUILD
+        add_custom_command(
+            TARGET _lightgbm_swig
+            POST_BUILD
             COMMAND "${Java_JAVAC_EXECUTABLE}" -d . java/*.java
-            COMMAND "${CMAKE_COMMAND}" -E copy_if_different "${PROJECT_SOURCE_DIR}/lib_lightgbm.dll" com/microsoft/ml/lightgbm/windows/x86_64
-            COMMAND "${CMAKE_COMMAND}" -E copy_if_different "${PROJECT_SOURCE_DIR}/lib_lightgbm_swig.dll" com/microsoft/ml/lightgbm/windows/x86_64
-            COMMAND "${Java_JAR_EXECUTABLE}" -cf lightgbmlib.jar com)
+            COMMAND
+              "${CMAKE_COMMAND}"
+              -E
+              copy_if_different
+              "${PROJECT_SOURCE_DIR}/lib_lightgbm.dll"
+              com/microsoft/ml/lightgbm/windows/x86_64
+            COMMAND
+              "${CMAKE_COMMAND}"
+              -E
+              copy_if_different
+              "${PROJECT_SOURCE_DIR}/lib_lightgbm_swig.dll"
+              com/microsoft/ml/lightgbm/windows/x86_64
+            COMMAND "${Java_JAR_EXECUTABLE}" -cf lightgbmlib.jar com
+        )
     else()
-        add_custom_command(TARGET _lightgbm_swig POST_BUILD
+        add_custom_command(
+            TARGET _lightgbm_swig
+            POST_BUILD
             COMMAND "${Java_JAVAC_EXECUTABLE}" -d . java/*.java
             COMMAND cp "${PROJECT_SOURCE_DIR}/Release/*.dll" com/microsoft/ml/lightgbm/windows/x86_64
-            COMMAND "${Java_JAR_EXECUTABLE}" -cf lightgbmlib.jar com)
+            COMMAND "${Java_JAR_EXECUTABLE}" -cf lightgbmlib.jar com
+        )
     endif()
   elseif(APPLE)
-    add_custom_command(TARGET _lightgbm_swig POST_BUILD
-            COMMAND "${Java_JAVAC_EXECUTABLE}" -d . java/*.java
-            COMMAND cp "${PROJECT_SOURCE_DIR}/*.dylib" com/microsoft/ml/lightgbm/osx/x86_64
-            COMMAND cp "${PROJECT_SOURCE_DIR}/lib_lightgbm_swig.jnilib" com/microsoft/ml/lightgbm/osx/x86_64/lib_lightgbm_swig.dylib
-            COMMAND "${Java_JAR_EXECUTABLE}" -cf lightgbmlib.jar com)
+    add_custom_command(
+        TARGET _lightgbm_swig
+        POST_BUILD
+        COMMAND "${Java_JAVAC_EXECUTABLE}" -d . java/*.java
+        COMMAND cp "${PROJECT_SOURCE_DIR}/*.dylib" com/microsoft/ml/lightgbm/osx/x86_64
+        COMMAND
+          cp
+          "${PROJECT_SOURCE_DIR}/lib_lightgbm_swig.jnilib"
+          com/microsoft/ml/lightgbm/osx/x86_64/lib_lightgbm_swig.dylib
+        COMMAND "${Java_JAR_EXECUTABLE}" -cf lightgbmlib.jar com
+    )
   else()
-    add_custom_command(TARGET _lightgbm_swig POST_BUILD
-      COMMAND "${Java_JAVAC_EXECUTABLE}" -d . java/*.java
-      COMMAND cp "${PROJECT_SOURCE_DIR}/*.so" com/microsoft/ml/lightgbm/linux/x86_64
-      COMMAND "${Java_JAR_EXECUTABLE}" -cf lightgbmlib.jar com)
+    add_custom_command(
+        TARGET _lightgbm_swig
+        POST_BUILD
+        COMMAND "${Java_JAVAC_EXECUTABLE}" -d . java/*.java
+        COMMAND cp "${PROJECT_SOURCE_DIR}/*.so" com/microsoft/ml/lightgbm/linux/x86_64
+        COMMAND "${Java_JAR_EXECUTABLE}" -cf lightgbmlib.jar com
+    )
   endif()
 endif()
 
@@ -525,9 +568,11 @@ if(BUILD_CPP_TEST)
   target_link_libraries(testlightgbm PRIVATE lightgbm_objs GTest::GTest)
 endif()
 
-install(TARGETS lightgbm _lightgbm
-        RUNTIME DESTINATION ${CMAKE_INSTALL_PREFIX}/bin
-        LIBRARY DESTINATION ${CMAKE_INSTALL_PREFIX}/lib
-        ARCHIVE DESTINATION ${CMAKE_INSTALL_PREFIX}/lib)
+install(
+  TARGETS lightgbm _lightgbm
+  RUNTIME DESTINATION ${CMAKE_INSTALL_PREFIX}/bin
+  LIBRARY DESTINATION ${CMAKE_INSTALL_PREFIX}/lib
+  ARCHIVE DESTINATION ${CMAKE_INSTALL_PREFIX}/lib
+)
 
 install(DIRECTORY ${LightGBM_HEADER_DIR}/LightGBM DESTINATION ${CMAKE_INSTALL_PREFIX}/include)
diff --git a/cmake/IntegratedOpenCL.cmake b/cmake/IntegratedOpenCL.cmake
@@ -31,7 +31,13 @@ if(NOT OpenCL-ICD-Loader_POPULATED)
   message(STATUS "Populated OpenCL ICD Loader")
 endif()
 list(APPEND INTEGRATED_OPENCL_INCLUDES ${OPENCL_ICD_LOADER_HEADERS_DIR})
-list(APPEND INTEGRATED_OPENCL_LIBRARIES ${opencl-icd-loader_BINARY_DIR}/Release/OpenCL.lib cfgmgr32.lib runtimeobject.lib)
+list(
+  APPEND
+  INTEGRATED_OPENCL_LIBRARIES
+    ${opencl-icd-loader_BINARY_DIR}/Release/OpenCL.lib
+    cfgmgr32.lib
+    runtimeobject.lib
+)
 list(APPEND INTEGRATED_OPENCL_DEFINITIONS CL_TARGET_OPENCL_VERSION=120)
 
 # Build Independent Boost libraries
@@ -42,8 +48,62 @@ set(BOOST_BASE "${PROJECT_BINARY_DIR}/Boost")
 set(BOOST_BOOTSTRAP "${BOOST_BASE}/source/bootstrap.bat")
 set(BOOST_BUILD "${BOOST_BASE}/source/b2.exe")
 set(BOOST_FLAGS "")
-list(APPEND BOOST_SUBMODULES "libs/algorithm" "libs/align" "libs/any" "libs/array" "libs/assert" "libs/bind" "libs/chrono" "libs/compute" "libs/concept_check" "libs/config" "libs/container" "libs/container_hash" "libs/core" "libs/detail" "libs/filesystem" "libs/foreach" "libs/format" "libs/function" "libs/function_types" "libs/fusion" "libs/headers" "libs/integer" "libs/io" "libs/iterator" "libs/lexical_cast" "libs/math" "libs/move" "libs/mpl" "libs/multi_index" "libs/numeric/conversion" "libs/optional" "libs/predef" "libs/preprocessor" "libs/property_tree" "libs/range" "libs/ratio" "libs/serialization" "libs/smart_ptr" "libs/static_assert" "libs/system" "libs/throw_exception" "libs/tuple" "libs/typeof" "libs/type_index" "libs/type_traits" "libs/utility" "libs/uuid" "libs/winapi" "tools/boost_install" "tools/build")
-ExternalProject_Add(Boost
+list(
+  APPEND
+  BOOST_SUBMODULES
+    "libs/algorithm"
+    "libs/align"
+    "libs/any"
+    "libs/array"
+    "libs/assert"
+    "libs/bind"
+    "libs/chrono"
+    "libs/compute"
+    "libs/concept_check"
+    "libs/config"
+    "libs/container"
+    "libs/container_hash"
+    "libs/core"
+    "libs/detail"
+    "libs/filesystem"
+    "libs/foreach"
+    "libs/format"
+    "libs/function"
+    "libs/function_types"
+    "libs/fusion"
+    "libs/headers"
+    "libs/integer"
+    "libs/io"
+    "libs/iterator"
+    "libs/lexical_cast"
+    "libs/math"
+    "libs/move"
+    "libs/mpl"
+    "libs/multi_index"
+    "libs/numeric/conversion"
+    "libs/optional"
+    "libs/predef"
+    "libs/preprocessor"
+    "libs/property_tree"
+    "libs/range"
+    "libs/ratio"
+    "libs/serialization"
+    "libs/smart_ptr"
+    "libs/static_assert"
+    "libs/system"
+    "libs/throw_exception"
+    "libs/tuple"
+    "libs/typeof"
+    "libs/type_index"
+    "libs/type_traits"
+    "libs/utility"
+    "libs/uuid"
+    "libs/winapi"
+    "tools/boost_install"
+    "tools/build"
+)
+ExternalProject_Add(
+  Boost
   TMP_DIR "${BOOST_BASE}/tmp"
   STAMP_DIR "${BOOST_BASE}/stamp"
   DOWNLOAD_DIR "${BOOST_BASE}/download"
@@ -57,7 +117,21 @@ ExternalProject_Add(Boost
   UPDATE_COMMAND ""
   PATCH_COMMAND ""
   CONFIGURE_COMMAND ${BOOST_BOOTSTRAP}
-  BUILD_COMMAND ${BOOST_BUILD} -sBOOST_ROOT=${BOOST_BASE}/source -a -q -j ${J} --with-headers --with-chrono --with-filesystem --with-system link=static runtime-link=shared variant=release threading=multi cxxflags="${BOOST_FLAGS}"
+  BUILD_COMMAND
+    ${BOOST_BUILD}
+    -sBOOST_ROOT=${BOOST_BASE}/source
+    -a
+    -q
+    -j ${J}
+    --with-headers
+    --with-chrono
+    --with-filesystem
+    --with-system
+    link=static
+    runtime-link=shared
+    variant=release
+    threading=multi
+    cxxflags="${BOOST_FLAGS}"
   INSTALL_COMMAND ""
 )
 set(BOOST_INCLUDE "${BOOST_BASE}/source" CACHE PATH "")
@@ -75,9 +149,21 @@ if(MSVC)
   else()
     message(FATAL_ERROR "Unrecognized MSVC version number: ${MSVC_VERSION}")
   endif()
-  list(APPEND INTEGRATED_OPENCL_LIBRARIES ${BOOST_LIBRARY}/libboost_filesystem-vc${MSVC_TOOLCHAIN_ID}-mt-x64-${BOOST_VERSION_UNDERSCORE}.lib)
-  list(APPEND INTEGRATED_OPENCL_LIBRARIES ${BOOST_LIBRARY}/libboost_system-vc${MSVC_TOOLCHAIN_ID}-mt-x64-${BOOST_VERSION_UNDERSCORE}.lib)
-  list(APPEND INTEGRATED_OPENCL_LIBRARIES ${BOOST_LIBRARY}/libboost_chrono-vc${MSVC_TOOLCHAIN_ID}-mt-x64-${BOOST_VERSION_UNDERSCORE}.lib)
+  list(
+    APPEND
+    INTEGRATED_OPENCL_LIBRARIES
+    ${BOOST_LIBRARY}/libboost_filesystem-vc${MSVC_TOOLCHAIN_ID}-mt-x64-${BOOST_VERSION_UNDERSCORE}.lib
+  )
+  list(
+    APPEND
+    INTEGRATED_OPENCL_LIBRARIES
+    ${BOOST_LIBRARY}/libboost_system-vc${MSVC_TOOLCHAIN_ID}-mt-x64-${BOOST_VERSION_UNDERSCORE}.lib
+  )
+  list(
+    APPEND
+    INTEGRATED_OPENCL_LIBRARIES
+    ${BOOST_LIBRARY}/libboost_chrono-vc${MSVC_TOOLCHAIN_ID}-mt-x64-${BOOST_VERSION_UNDERSCORE}.lib
+  )
 else()
   message(FATAL_ERROR "Integrated OpenCL build is not yet available for MinGW")
 endif()

diff --git a/cmake/Sanitizer.cmake b/cmake/Sanitizer.cmake
@@ -28,14 +28,12 @@ macro(enable_sanitizers SANITIZERS)
     string(TOLOWER ${_san} _san)
     if(_san MATCHES "thread")
       if(${_use_other_sanitizers})
-        message(FATAL_ERROR
-          "thread sanitizer is not compatible with ${_san} sanitizer.")
+        message(FATAL_ERROR "thread sanitizer is not compatible with ${_san} sanitizer.")
       endif()
       set(_use_thread_sanitizer 1)
     else()
       if(${_use_thread_sanitizer})
-        message(FATAL_ERROR
-          "${_san} sanitizer is not compatible with thread sanitizer.")
+        message(FATAL_ERROR "${_san} sanitizer is not compatible with thread sanitizer.")
       endif()
       set(_use_other_sanitizers 1)
     endif()